* [PATCH] Fix typo in org-find-exact-headling-in-buffer
@ 2010-08-23 22:04 Jambunathan K
2010-08-24 7:25 ` Noorul Islam K M
2010-09-02 14:15 ` [PATCH] " Bastien
0 siblings, 2 replies; 5+ messages in thread
From: Jambunathan K @ 2010-08-23 22:04 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 70 bytes --]
Still thinkling but have no inkling about headling.
Jambunathan K.
[-- Attachment #2: Type: text/plain, Size: 2768 bytes --]
From a49dcabccf5d4589d553115d7ce8a648ab4328f2 Mon Sep 17 00:00:00 2001
From: Jambunathan K <kjambunathan@gmail.com>
Date: Tue, 24 Aug 2010 03:05:04 +0530
Subject: [PATCH] Fix typo in org-find-exact-headling-in-buffer
* lisp/org.el (org-find-exact-heading-in-buffer): Renamed from
org-find-exact-headling-in-buffer.
* contrib/lisp/org-wikinodes.el (org-wikinodes-follow-link): Fix typo in
org-find-exact-headling-in-buffer
TINYCHANGE.
---
contrib/lisp/org-wikinodes.el | 6 +++---
lisp/org.el | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/contrib/lisp/org-wikinodes.el b/contrib/lisp/org-wikinodes.el
index 0a00052..e07a8e4 100644
--- a/contrib/lisp/org-wikinodes.el
+++ b/contrib/lisp/org-wikinodes.el
@@ -119,10 +119,10 @@ setting of `org-wikinodes-create-targets'."
(let ((create org-wikinodes-create-targets)
visiting buffer m pos file rpl)
(setq pos
- (or (org-find-exact-headling-in-buffer target (current-buffer))
+ (or (org-find-exact-heading-in-buffer target (current-buffer))
(and (eq org-wikinodes-scope 'directory)
(setq file (org-wikinodes-which-file target))
- (org-find-exact-headling-in-buffer
+ (org-find-exact-heading-in-buffer
target (or (get-file-buffer file)
(find-file-noselect file))))))
(if pos
@@ -288,7 +288,7 @@ with working links."
(delete-region (match-beginning 0) (match-end 0))
(save-match-data
(cond
- ((org-find-exact-headling-in-buffer link (current-buffer))
+ ((org-find-exact-heading-in-buffer link (current-buffer))
;; Found in current buffer
(insert (format "[[#%s][%s]]" link link)))
((eq org-wikinodes-scope 'file)
diff --git a/lisp/org.el b/lisp/org.el
index 15379ef..134ac56 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -14033,7 +14033,7 @@ only headings."
(when (org-on-heading-p)
(move-marker (make-marker) (point))))))))
-(defun org-find-exact-headling-in-buffer (heading &optional buffer pos-only)
+(defun org-find-exact-heading-in-buffer (heading &optional buffer pos-only)
"Find node HEADING in BUFFER.
Return a marker to the heading if it was found, or nil if not.
If POS-ONLY is set, return just the position instead of a marker.
@@ -14064,7 +14064,7 @@ When the target headline is found, return a marker to this location."
(message "trying %s" file)
(setq visiting (org-find-base-buffer-visiting file))
(setq buffer (or visiting (find-file-noselect file)))
- (setq m (org-find-exact-headling-in-buffer
+ (setq m (org-find-exact-heading-in-buffer
heading buffer))
(when (and (not m) (not visiting)) (kill-buffer buffer))
(and m (throw 'found m))))))
--
1.7.0.4
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: Fix typo in org-find-exact-headling-in-buffer
2010-08-23 22:04 [PATCH] Fix typo in org-find-exact-headling-in-buffer Jambunathan K
@ 2010-08-24 7:25 ` Noorul Islam K M
2010-09-02 14:15 ` [PATCH] " Bastien
1 sibling, 0 replies; 5+ messages in thread
From: Noorul Islam K M @ 2010-08-24 7:25 UTC (permalink / raw)
To: Jambunathan K; +Cc: emacs-orgmode
Jambunathan K <kjambunathan@gmail.com> writes:
> Still thinkling but have no inkling about headling.
>
> Jambunathan K.
>
> From a49dcabccf5d4589d553115d7ce8a648ab4328f2 Mon Sep 17 00:00:00 2001
> From: Jambunathan K <kjambunathan@gmail.com>
> Date: Tue, 24 Aug 2010 03:05:04 +0530
> Subject: [PATCH] Fix typo in org-find-exact-headling-in-buffer
>
> * lisp/org.el (org-find-exact-heading-in-buffer): Renamed from
> org-find-exact-headling-in-buffer.
> * contrib/lisp/org-wikinodes.el (org-wikinodes-follow-link): Fix typo in
> org-find-exact-headling-in-buffer
>
> TINYCHANGE.
> ---
> contrib/lisp/org-wikinodes.el | 6 +++---
> lisp/org.el | 4 ++--
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/contrib/lisp/org-wikinodes.el b/contrib/lisp/org-wikinodes.el
> index 0a00052..e07a8e4 100644
> --- a/contrib/lisp/org-wikinodes.el
> +++ b/contrib/lisp/org-wikinodes.el
> @@ -119,10 +119,10 @@ setting of `org-wikinodes-create-targets'."
> (let ((create org-wikinodes-create-targets)
> visiting buffer m pos file rpl)
> (setq pos
> - (or (org-find-exact-headling-in-buffer target (current-buffer))
> + (or (org-find-exact-heading-in-buffer target (current-buffer))
> (and (eq org-wikinodes-scope 'directory)
> (setq file (org-wikinodes-which-file target))
> - (org-find-exact-headling-in-buffer
> + (org-find-exact-heading-in-buffer
> target (or (get-file-buffer file)
> (find-file-noselect file))))))
> (if pos
> @@ -288,7 +288,7 @@ with working links."
> (delete-region (match-beginning 0) (match-end 0))
> (save-match-data
> (cond
> - ((org-find-exact-headling-in-buffer link (current-buffer))
> + ((org-find-exact-heading-in-buffer link (current-buffer))
> ;; Found in current buffer
> (insert (format "[[#%s][%s]]" link link)))
> ((eq org-wikinodes-scope 'file)
> diff --git a/lisp/org.el b/lisp/org.el
> index 15379ef..134ac56 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14033,7 +14033,7 @@ only headings."
> (when (org-on-heading-p)
> (move-marker (make-marker) (point))))))))
>
> -(defun org-find-exact-headling-in-buffer (heading &optional buffer pos-only)
> +(defun org-find-exact-heading-in-buffer (heading &optional buffer pos-only)
> "Find node HEADING in BUFFER.
> Return a marker to the heading if it was found, or nil if not.
> If POS-ONLY is set, return just the position instead of a marker.
> @@ -14064,7 +14064,7 @@ When the target headline is found, return a marker to this location."
> (message "trying %s" file)
> (setq visiting (org-find-base-buffer-visiting file))
> (setq buffer (or visiting (find-file-noselect file)))
> - (setq m (org-find-exact-headling-in-buffer
> + (setq m (org-find-exact-heading-in-buffer
> heading buffer))
> (when (and (not m) (not visiting)) (kill-buffer buffer))
> (and m (throw 'found m))))))
It might not be a typo. Looks like deliberate.
Thanks
Noorul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix typo in org-find-exact-headling-in-buffer
2010-08-23 22:04 [PATCH] Fix typo in org-find-exact-headling-in-buffer Jambunathan K
2010-08-24 7:25 ` Noorul Islam K M
@ 2010-09-02 14:15 ` Bastien
2010-09-02 14:29 ` Carsten Dominik
1 sibling, 1 reply; 5+ messages in thread
From: Bastien @ 2010-09-02 14:15 UTC (permalink / raw)
To: Jambunathan K; +Cc: emacs-orgmode
Jambunathan K <kjambunathan@gmail.com> writes:
> Still thinkling but have no inkling about headling.
I fixed this:
s/org-find-exact-headling-in-buffer/org-find-exact-headline-in-buffer
The "org-find-exact-headline-in-buffer" function is not to be confused
with "org-find-exact-heading-in-directory"... yep, a bit confusing :)
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix typo in org-find-exact-headling-in-buffer
2010-09-02 14:15 ` [PATCH] " Bastien
@ 2010-09-02 14:29 ` Carsten Dominik
2010-09-02 14:47 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-09-02 14:29 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode, Jambunathan K
On Sep 2, 2010, at 4:15 PM, Bastien wrote:
> Jambunathan K <kjambunathan@gmail.com> writes:
>
>> Still thinkling but have no inkling about headling.
>
> I fixed this:
>
> s/org-find-exact-headling-in-buffer/org-find-exact-headline-in-buffer
>
> The "org-find-exact-headline-in-buffer" function is not to be confused
> with "org-find-exact-heading-in-directory"... yep, a bit confusing :)
Ah, there was still one of those left in the wikinodes. Thanks for
finding this.
Is anyone actually using the wikinodes module? I had 0 feedback after I
installed it.
- Carsten
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-09-02 15:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-23 22:04 [PATCH] Fix typo in org-find-exact-headling-in-buffer Jambunathan K
2010-08-24 7:25 ` Noorul Islam K M
2010-09-02 14:15 ` [PATCH] " Bastien
2010-09-02 14:29 ` Carsten Dominik
2010-09-02 14:47 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).