From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-orgmode@gnu.org
Subject: [PATCH] sort TODO entries more usefully
Date: Sun, 25 May 2014 13:33:15 +0800 [thread overview]
Message-ID: <8738fyctic.fsf@ericabrahamsen.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 618 bytes --]
For some reason I've been sorting lots of TODOs recently, and found the
default behavior of org-sort-entries a little odd. It sorts according to
the order found in org-todo-keywords-1, which apparently just comes from
the order the keywords were scanned during setup. I don't think that's
all that useful, so the attached patch sorts first by
org-not-done-keywords vs org-done-keywords, then alphabetically.
Headings with no keywords sort "big".
I'm not very experienced at logical tricks like sorting strategies, and
I'd be very curious to see if anyone had a more concise way of
expressing the comp function.
Eric
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Sort-TODO-entries-more-usefully.patch --]
[-- Type: text/x-diff, Size: 1978 bytes --]
From d19c86e720feb65e0aef7a1fff9bf19bd75dbcf4 Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Sun, 25 May 2014 12:18:52 +0800
Subject: [PATCH] Sort TODO entries more usefully
lisp/org.el (org-sort-entries, org-compare-todos-subr): Change the
sort routine for TODO entries so that they are first sorted by
keyword time (done or not done) and then
alphabetically. Entries with no TODO keyword at all are sorted
"big".
---
lisp/org.el | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 9f14c44..2400ddf 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -8703,6 +8703,15 @@ Optional argument WITH-CASE means sort case-sensitively."
(setq s (substring st 1 -1)))
s)
+(defun org-compare-todos-subr (a b)
+ (if (or (and (member a org-not-done-keywords)
+ (member b org-not-done-keywords))
+ (and (member a org-done-keywords)
+ (member b org-done-keywords)))
+ (string< a b)
+ (or (member a org-done-keywords)
+ (consp a))))
+
(defvar org-priority-regexp) ; defined later in the file
(defvar org-after-sorting-entries-or-items-hook nil
@@ -8904,8 +8913,8 @@ When sorting is done, call `org-after-sorting-entries-or-items-hook'."
(or (org-entry-get nil property) ""))
((= dcst ?o)
(if (looking-at org-complex-heading-regexp)
- (- 9999 (length (member (match-string 2)
- org-todo-keywords-1)))))
+ (car (member (match-string 2)
+ org-todo-keywords-1))))
((= dcst ?f)
(if getkey-func
(progn
@@ -8918,6 +8927,7 @@ When sorting is done, call `org-after-sorting-entries-or-items-hook'."
(cond
((= dcst ?a) 'string<)
((= dcst ?f) compare-func)
+ ((= dcst ?o) 'org-compare-todos-subr)
((member dcst '(?p ?t ?s ?d ?c ?k)) '<)))))
(run-hooks 'org-after-sorting-entries-or-items-hook)
;; Reset the clock marker if needed
--
1.9.3
next reply other threads:[~2014-05-25 5:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 5:33 Eric Abrahamsen [this message]
2014-05-25 6:32 ` [PATCH] sort TODO entries more usefully Bastien
2014-05-25 11:51 ` Eric Abrahamsen
2014-05-26 5:10 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738fyctic.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).