* [org-drill] Suggestion to fix the drop of org-end-of-meta-data-and-drawers
@ 2015-02-13 7:25 Marco Wahl
2015-02-13 13:06 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Marco Wahl @ 2015-02-13 7:25 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Paul Sexton
Hi,
since the drop of org-end-of-meta-data-and-drawers contrib/org-drill
fails in master.
AFAICT a possible fix is:
#v+
diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
index a0d33aa..8154904 100644
--- a/contrib/lisp/org-drill.el
+++ b/contrib/lisp/org-drill.el
@@ -1708,7 +1708,7 @@ Note: does not actually alter the item."
(org-back-to-heading t)
(let ((lim (save-excursion
(outline-next-heading) (point))))
- (org-end-of-meta-data-and-drawers)
+ (org-end-of-meta-data t)
(or (>= (point) lim)
(null (re-search-forward "[[:graph:]]" lim t))))))
#v-
Is it sufficient to apply this fix to master? Am I missing something?
Best regards,
Marco
--
http://www.wahlzone.de
GPG: 0x49010A040A3AE6F2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [org-drill] Suggestion to fix the drop of org-end-of-meta-data-and-drawers
2015-02-13 7:25 [org-drill] Suggestion to fix the drop of org-end-of-meta-data-and-drawers Marco Wahl
@ 2015-02-13 13:06 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-02-13 13:06 UTC (permalink / raw)
To: Marco Wahl; +Cc: Paul Sexton, emacs-orgmode
Hello,
Marco Wahl <marcowahlsoft@gmail.com> writes:
> AFAICT a possible fix is:
>
> #v+
> diff --git a/contrib/lisp/org-drill.el b/contrib/lisp/org-drill.el
> index a0d33aa..8154904 100644
> --- a/contrib/lisp/org-drill.el
> +++ b/contrib/lisp/org-drill.el
> @@ -1708,7 +1708,7 @@ Note: does not actually alter the item."
> (org-back-to-heading t)
> (let ((lim (save-excursion
> (outline-next-heading) (point))))
> - (org-end-of-meta-data-and-drawers)
> + (org-end-of-meta-data t)
> (or (>= (point) lim)
> (null (re-search-forward "[[:graph:]]" lim t))))))
> #v-
>
> Is it sufficient to apply this fix to master?
This is correct. Thank you for taking care of it.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-13 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-13 7:25 [org-drill] Suggestion to fix the drop of org-end-of-meta-data-and-drawers Marco Wahl
2015-02-13 13:06 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).