Re: Two bugs in org-indent (plus a fix to correct one of them)

From: David Maus <dmaus@ictsoc.de>
To: William Henney <whenney@gmail.com>
Cc: emacs-org <emacs-orgmode@gnu.org>
Subject: Re: Two bugs in org-indent (plus a fix to correct one of them)
Date: Tue, 15 Jun 2010 13:02:06 +0200	[thread overview]
Message-ID: <871vc8ftjl.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <AANLkTil3cSVy2SjQK0_u0JcakAV7mYjQaZVtBpr7nX3I@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1723 bytes --]

William Henney wrote:
>Hi all

>1. If one sets org-indent-indentation-per-level to any value other
>than the default of 2, then the indentation of lines following a
>heading is not correct. I seem to have managed to fix this by changing
>line 231 of org-indent.el from

>		 n (* (or level 0) org-indent-indentation-per-level))))))))

>to

>		 n (+ 2 (* (1- (or level 0)) org-indent-indentation-per-level)))))))))

>Tested with org-indent-indentation-per-level = 0, 1, 2, and 3.

I don't understand this: The original formula sets the indentation
level of n times org-indent-indentation-per-level with n being the
outline level.  Why do you consider this not being correct?[1]

>2. org-indent fails to play nicely with org-inlinetask in two ways

>   i) It destroys the special fontification of the inline task's
>leading stars, even if org-indent-mode-turns-on-hiding-stars is set to
>nil

>   ii) Any text after an inline task's END statement is soft-indented
>as though it were part of the inline task, whereas the indentation
>should ideally return to what it was before the inline task. Of
>course, this is also a problem when org-indent is turned off, if you
>try to automatically hard-indent using TAB. However, in that case you
>can adjust by hand the indentation of the first line after the inline
>task, and then all the following lines will indent correctly. With
>org-indent the problem is much worse since there is no way of
>adjusting the soft indents by hand.

Yes, I can confirm these two things.

  -- Davie

[1] Besides, the suggested function does not consider no outline
level.  I.e. returns negative indentation.
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode