From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Two bugs in org-indent (plus a fix to correct one of them) Date: Tue, 15 Jun 2010 13:02:06 +0200 Message-ID: <871vc8ftjl.wl%dmaus@ictsoc.de> References: Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============1411531048==" Return-path: Received: from [140.186.70.92] (port=55136 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OOTve-0008Bp-Gw for emacs-orgmode@gnu.org; Tue, 15 Jun 2010 07:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OOTvZ-0004rI-Oc for emacs-orgmode@gnu.org; Tue, 15 Jun 2010 07:03:38 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:57174) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OOTvZ-0004qz-Ji for emacs-orgmode@gnu.org; Tue, 15 Jun 2010 07:03:33 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: William Henney Cc: emacs-org --===============1411531048== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Tue_Jun_15_13:02:06_2010-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Tue_Jun_15_13:02:06_2010-1 Content-Type: text/plain; charset=US-ASCII William Henney wrote: >Hi all >1. If one sets org-indent-indentation-per-level to any value other >than the default of 2, then the indentation of lines following a >heading is not correct. I seem to have managed to fix this by changing >line 231 of org-indent.el from > n (* (or level 0) org-indent-indentation-per-level)))))))) >to > n (+ 2 (* (1- (or level 0)) org-indent-indentation-per-level))))))))) >Tested with org-indent-indentation-per-level = 0, 1, 2, and 3. I don't understand this: The original formula sets the indentation level of n times org-indent-indentation-per-level with n being the outline level. Why do you consider this not being correct?[1] >2. org-indent fails to play nicely with org-inlinetask in two ways > i) It destroys the special fontification of the inline task's >leading stars, even if org-indent-mode-turns-on-hiding-stars is set to >nil > ii) Any text after an inline task's END statement is soft-indented >as though it were part of the inline task, whereas the indentation >should ideally return to what it was before the inline task. Of >course, this is also a problem when org-indent is turned off, if you >try to automatically hard-indent using TAB. However, in that case you >can adjust by hand the indentation of the first line after the inline >task, and then all the following lines will indent correctly. With >org-indent the problem is much worse since there is no way of >adjusting the soft indents by hand. Yes, I can confirm these two things. -- Davie [1] Besides, the suggested function does not consider no outline level. I.e. returns negative indentation. -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Tue_Jun_15_13:02:06_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkwXXa4ACgkQma24O1pEeOYmsQD/bo1jHglyBcG4YEqJmhFjyMsO 7qdAp02Y2d5sdEIHtNQBAN3ZcFHe8VnrmdnLZld5u46Mu0MYqp8xhxPV58OnuDf4 =W1EY -----END PGP SIGNATURE----- --pgp-sign-Multipart_Tue_Jun_15_13:02:06_2010-1-- --===============1411531048== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1411531048==--