emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Martyn Jago <martyn.jago@btinternet.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fixes to inline src block execution
Date: Mon, 05 Sep 2011 21:31:06 -0600	[thread overview]
Message-ID: <871uvu1h51.fsf@gmail.com> (raw)
In-Reply-To: <m27h5m4nlj.fsf@btinternet.com> (Martyn Jago's message of "Mon, 05 Sep 2011 23:43:20 +0100")

Martyn Jago <martyn.jago@btinternet.com> writes:

> Hi
>
> Some fixes to inline src block execution via org-ctrl-c-ctrl-c
> where point is beyond white-space in the inline src block body...
>
> * Start Pomodoro
>  #src_emacs-lisp[:results silent]{( org-timer-set-timer 25 )} 
>                          ^
> ,------------------------'
> | C-c C-c execution
> | was broken beyond 
> | here
> `------------------
>
> Also fixes to inline src block execution where the inline src block 
> happens to be on the first line of a buffer. 
>
> I've included tests and test data.
>

Hi Martyn,

This looks great.  I would like to apply this patch but it breaks unit
tests at least one of which existed previously and was passing.  Would
you mind taking a look at these unit tests to see if your patch breaks
existing behavior?

,----[ert output from `org-test-run-all-tests']
| F test-org-babel/inline-src-blocks
|     (wrong-type-argument consp nil)
| 
| F test-org-babel/org-babel-get-inline-src-block-matches
|     (ert-test-failed
|      ((should
|        (org-babel-get-inline-src-block-matches))
|       :form
|       (org-babel-get-inline-src-block-matches)
|       :value nil))
| 
| F test-org-babel/parse-header-args
|     (ert-test-failed
|      ((should
|        (= 14
|           (org-babel-execute-src-block)))
|       :form
|       (= 14 13)
|       :value nil))
`----

Thanks! -- Eric

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2011-09-06  3:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 22:43 [PATCH] Fixes to inline src block execution Martyn Jago
2011-09-06  3:31 ` Eric Schulte [this message]
2011-09-06  8:19   ` Martyn Jago
2011-09-06 15:12     ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871uvu1h51.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=martyn.jago@btinternet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).