From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH] Fixes to inline src block execution Date: Mon, 05 Sep 2011 21:31:06 -0600 Message-ID: <871uvu1h51.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:44479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0mNX-0007XW-7Y for emacs-orgmode@gnu.org; Mon, 05 Sep 2011 23:31:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R0mNV-00069h-Nb for emacs-orgmode@gnu.org; Mon, 05 Sep 2011 23:31:15 -0400 Received: from mail-iy0-f169.google.com ([209.85.210.169]:37291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R0mNV-00069c-Fd for emacs-orgmode@gnu.org; Mon, 05 Sep 2011 23:31:13 -0400 Received: by iagv1 with SMTP id v1so8365464iag.0 for ; Mon, 05 Sep 2011 20:31:12 -0700 (PDT) In-Reply-To: (Martyn Jago's message of "Mon, 05 Sep 2011 23:43:20 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Martyn Jago Cc: emacs-orgmode@gnu.org Martyn Jago writes: > Hi > > Some fixes to inline src block execution via org-ctrl-c-ctrl-c > where point is beyond white-space in the inline src block body... > > * Start Pomodoro > #src_emacs-lisp[:results silent]{( org-timer-set-timer 25 )} > ^ > ,------------------------' > | C-c C-c execution > | was broken beyond > | here > `------------------ > > Also fixes to inline src block execution where the inline src block > happens to be on the first line of a buffer. > > I've included tests and test data. > Hi Martyn, This looks great. I would like to apply this patch but it breaks unit tests at least one of which existed previously and was passing. Would you mind taking a look at these unit tests to see if your patch breaks existing behavior? ,----[ert output from `org-test-run-all-tests'] | F test-org-babel/inline-src-blocks | (wrong-type-argument consp nil) | | F test-org-babel/org-babel-get-inline-src-block-matches | (ert-test-failed | ((should | (org-babel-get-inline-src-block-matches)) | :form | (org-babel-get-inline-src-block-matches) | :value nil)) | | F test-org-babel/parse-header-args | (ert-test-failed | ((should | (= 14 | (org-babel-execute-src-block))) | :form | (= 14 13) | :value nil)) `---- Thanks! -- Eric -- Eric Schulte http://cs.unm.edu/~eschulte/