From: Bastien <bzg@altern.org>
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Escape link path only if path contains space or non-ascii character
Date: Tue, 20 Dec 2011 23:54:56 +0100 [thread overview]
Message-ID: <871uryj1kv.fsf@gnu.org> (raw)
In-Reply-To: <871us1lojx.wl%dmaus@ictsoc.de> (David Maus's message of "Sun, 18 Dec 2011 19:31:14 +0100")
Hi David,
David Maus <dmaus@ictsoc.de> writes:
> Attached patch should take care of mistakenly double-escaped links as
> reported by Jeff Horn in <http://article.gmane.org/gmane.emacs.orgmode/48731>.
>
> This patch might break `org-open-at-point' for some users if the
> target application does not deal with (possibly) unescaped URLs. The
> alternative to the guesswork would require parsing und analyzing the
> link and its components (path, query, fragment) and check for
> characters that absolutely need escaping depeding on the link type.
>
> Hopefully this solution is good enough.
Guessing is probably safe here -- tests will tell. Thanks for
following this issue so closely and thanks for the patch! I've
now applied it.
Best,
--
Bastien
prev parent reply other threads:[~2011-12-20 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-18 18:31 [PATCH] Escape link path only if path contains space or non-ascii character David Maus
2011-12-20 22:54 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uryj1kv.fsf@gnu.org \
--to=bzg@altern.org \
--cc=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).