From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: [PATCH] Escape link path only if path contains space or
 non-ascii character
Date: Tue, 20 Dec 2011 23:54:56 +0100
Message-ID: <871uryj1kv.fsf@gnu.org>
References: <871us1lojx.wl%dmaus@ictsoc.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([140.186.70.92]:56345)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Rd8ZJ-0002al-8R
	for emacs-orgmode@gnu.org; Tue, 20 Dec 2011 17:53:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Rd8ZI-0006SM-1s
	for emacs-orgmode@gnu.org; Tue, 20 Dec 2011 17:53:57 -0500
Received: from mail-ww0-f49.google.com ([74.125.82.49]:48107)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@googlemail.com>) id 1Rd8ZH-0006S9-Su
	for emacs-orgmode@gnu.org; Tue, 20 Dec 2011 17:53:56 -0500
Received: by wgbdt11 with SMTP id dt11so10756375wgb.30
	for <emacs-orgmode@gnu.org>; Tue, 20 Dec 2011 14:53:55 -0800 (PST)
In-Reply-To: <871us1lojx.wl%dmaus@ictsoc.de> (David Maus's message of "Sun, 18
	Dec 2011 19:31:14 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: David Maus <dmaus@ictsoc.de>
Cc: emacs-orgmode@gnu.org

Hi David,

David Maus <dmaus@ictsoc.de> writes:

> Attached patch should take care of mistakenly double-escaped links as
> reported by Jeff Horn in <http://article.gmane.org/gmane.emacs.orgmode/48731>.
>
> This patch might break `org-open-at-point' for some users if the
> target application does not deal with (possibly) unescaped URLs. The
> alternative to the guesswork would require parsing und analyzing the
> link and its components (path, query, fragment) and check for
> characters that absolutely need escaping depeding on the link type.
>
> Hopefully this solution is good enough.

Guessing is probably safe here -- tests will tell.  Thanks for 
following this issue so closely and thanks for the patch!  I've
now applied it.

Best,

-- 
 Bastien