From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Richard Y. Kim" <emacs18@gmail.com>
Cc: Emacs-orgmode@gnu.org
Subject: Re: patch to add new link type "infoi" that leverages Info-index command
Date: Sun, 16 Nov 2014 00:21:36 +0100 [thread overview]
Message-ID: <871tp4t5hb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <qtm4mu05mkk.fsf@gmail.com> (Richard Y. Kim's message of "Sat, 15 Nov 2014 10:46:19 -0800")
emacs18@gmail.com (Richard Y. Kim) writes:
> Thanks for your feedback. Attached is new patch which incorporates all
> your suggestions
Applied. Thank you.
> except the following:
>
>> Not directly related to your patch, but shouldn't it be
>>
>> (user-error "Could not open: %s" name)
>
> I'm not sure what you mean by this. Do you mean that the verb "open" is
> more approrpriate than "find" in the error message, i.e., "Could not
> open" rather than "Could not find"? If so, then it seems like "find" is
> more appropriate since "open" seems like there was a problem with
> opening a file when the problem is that a particular node was not found
> after successfully opening a file. Please let me know if I
> misunderstood. Thanks again for your valuable feedbacks.
This is simpler than that. I was just saying that (user-error ...) was
probably more appropriate than (message ...) in the last line of the
function. I changed that in another patch.
> Subject: [PATCH] org-info: try info index if info node is not found
Nitpick: Missing capitals after the colons. I fixed it in the patch.
> + (user-error (format "Could not find '%s' node or index entry"
> + nodename-or-index))))))
I changed this to (user-error "Could not ..." nodename-or-index) since
`format' is not necessary.
Regards,
prev parent reply other threads:[~2014-11-15 23:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 18:23 patch to add new link type "infoi" that leverages Info-index command Richard Kim
2014-11-06 18:41 ` Nicolas Goaziou
2014-11-10 3:58 ` Richard Kim
2014-11-10 9:17 ` Nicolas Goaziou
2014-11-15 18:46 ` Richard Y. Kim
2014-11-15 23:21 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tp4t5hb.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=Emacs-orgmode@gnu.org \
--cc=emacs18@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).