From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: patch to add new link type "infoi" that leverages Info-index
 command
Date: Sun, 16 Nov 2014 00:21:36 +0100
Message-ID: <871tp4t5hb.fsf@nicolasgoaziou.fr>
References: <CAFq8O8sVXx9hj_tPih9q_qQsEEMCYbH3tAziwtMRKHxL1yqOFQ@mail.gmail.com>
	<87k338qii9.fsf@nicolasgoaziou.fr>
	<CAFq8O8sWXQ93irE+S1o1oWa-PVGhPe_DB-a=eFsfgUWCx_QZCw@mail.gmail.com>
	<87y4rjqusd.fsf@nicolasgoaziou.fr> <qtm4mu05mkk.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50481)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1XpmeF-0008VR-64
	for Emacs-orgmode@gnu.org; Sat, 15 Nov 2014 18:21:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Xpme5-0007cz-0F
	for Emacs-orgmode@gnu.org; Sat, 15 Nov 2014 18:20:55 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59628)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1Xpme4-0007ct-Ph
	for Emacs-orgmode@gnu.org; Sat, 15 Nov 2014 18:20:44 -0500
In-Reply-To: <qtm4mu05mkk.fsf@gmail.com> (Richard Y. Kim's message of "Sat, 15
	Nov 2014 10:46:19 -0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: "Richard Y. Kim" <emacs18@gmail.com>
Cc: Emacs-orgmode@gnu.org

emacs18@gmail.com (Richard Y. Kim) writes:

> Thanks for your feedback.  Attached is new patch which incorporates all
> your suggestions

Applied. Thank you.

> except the following:
>
>> Not directly related to your patch, but shouldn't it be
>>
>>   (user-error "Could not open: %s" name)
>
> I'm not sure what you mean by this.  Do you mean that the verb "open" is
> more approrpriate than "find" in the error message, i.e., "Could not
> open" rather than "Could not find"?  If so, then it seems like "find" is
> more appropriate since "open" seems like there was a problem with
> opening a file when the problem is that a particular node was not found
> after successfully opening a file.  Please let me know if I
> misunderstood.  Thanks again for your valuable feedbacks.

This is simpler than that. I was just saying that (user-error ...) was
probably more appropriate than (message ...) in the last line of the
function. I changed that in another patch.

> Subject: [PATCH] org-info: try info index if info node is not found

Nitpick: Missing capitals after the colons. I fixed it in the patch.
> +			(user-error (format "Could not find '%s' node or index entry" 
> +					    nodename-or-index))))))

I changed this to (user-error "Could not ..." nodename-or-index) since
`format' is not necessary.


Regards,