emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bjarte Johansen <bjarte.johansen@infomedia.uib.no>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: ob-sed
Date: Fri, 29 May 2015 11:00:45 +0200	[thread overview]
Message-ID: <871thz3ghu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <751618D6-4EE2-4803-A550-EECE21006ABA@infomedia.uib.no> (Bjarte Johansen's message of "Thu, 28 May 2015 13:47:59 +0200")

Bjarte Johansen <bjarte.johansen@infomedia.uib.no> writes:

> I think I have addressed all your comments in the attached patch.

Thank you. Some more comments follow.

> Subject: [PATCH] Org Babel now supports sed scripts

You should add something like the following to your commit message:

  * doc/org.texi: Signal new Babel language

  * lisp/ob-sed.el:
  * testing/examples/ob-sed-test.org:
  * testing/lisp/test-ob-sed.el: New files.

> -@item GNU Screen @tab screen @tab shell @tab sh 
> -@item SQL @tab sql @tab SQLite @tab sqlite
> +@item GNU Screen @tab screen Sed @tab sed
> +@item @tab shell @tab sh @item SQL @tab sql
> +@item @tab SQLite @tab sqlite @tab @tab

This looks wrong. I think it should be:

  @item GNU Screen @tab screen @tab Sed @tab sed
  @item shell @tab sh @tab SQL @tab sql
  @item SQLite @tab sqlite @tab @tab

> +;;; Usage:
> +
> +;; Add to your Emacs config:
> +
> +;; (org-babel-do-load-languages
> +;;  'org-babel-load-languages
> +;;  '((sed . t)))

You may want to introduce usage for :cmd-line and :in-file arguments in
"Usage" section.

> +(defconst org-babel-header-args:sed
> +  '((:cmd-line :any
> +     :in-file  :any))
> +  "Sed specific header arguments.")

It should be

  '((:cmd-line . :any)
    (:in-file  . :any))

See, for example `org-babel-header-args:R'

> +(defun org-babel-execute:sed (body params)
> +  "Execute a block of sed code with Org Babel.
> +BODY is the source inside a sed source block and PARAMS is an
> +association list over the source block configurations. This
                                                        ^^^
                                                     two spaces


Regards,

next prev parent reply	other threads:[~2015-05-29  9:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27  8:51 ob-sed Bjarte Johansen
2015-05-27  8:56 ` ob-sed Bjarte Johansen
2015-05-27 21:31   ` ob-sed Nicolas Goaziou
2015-05-28 11:47     ` ob-sed Bjarte Johansen
2015-05-29  9:00       ` Nicolas Goaziou [this message]
2015-05-29 13:32         ` ob-sed Bjarte Johansen
2015-05-29 17:08           ` ob-sed Suvayu Ali
2015-05-30 12:32           ` ob-sed Nicolas Goaziou
2015-05-30 12:36             ` ob-sed Bjarte Johansen
2015-05-30 13:01               ` ob-sed Nicolas Goaziou
2015-05-31  2:08               ` ob-sed Nick Dokos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871thz3ghu.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bjarte.johansen@infomedia.uib.no \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).