From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: ob-sed
Date: Fri, 29 May 2015 11:00:45 +0200
Message-ID: <871thz3ghu.fsf@nicolasgoaziou.fr>
References: <3C35DA19-1BA3-4249-9128-99DDA0F4752D@infomedia.uib.no>
	<D5085DF7-B664-4969-8122-2D5093E55E84@infomedia.uib.no>
	<877frtd7wi.fsf@nicolasgoaziou.fr>
	<751618D6-4EE2-4803-A550-EECE21006ABA@infomedia.uib.no>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YyG9E-00058u-4F
	for emacs-orgmode@gnu.org; Fri, 29 May 2015 05:00:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YyG99-0000ON-TO
	for emacs-orgmode@gnu.org; Fri, 29 May 2015 05:00:12 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:40826)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YyG99-0000JW-Nz
	for emacs-orgmode@gnu.org; Fri, 29 May 2015 05:00:07 -0400
In-Reply-To: <751618D6-4EE2-4803-A550-EECE21006ABA@infomedia.uib.no> (Bjarte
	Johansen's message of "Thu, 28 May 2015 13:47:59 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Bjarte Johansen <bjarte.johansen@infomedia.uib.no>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Bjarte Johansen <bjarte.johansen@infomedia.uib.no> writes:

> I think I have addressed all your comments in the attached patch.

Thank you. Some more comments follow.

> Subject: [PATCH] Org Babel now supports sed scripts

You should add something like the following to your commit message:

  * doc/org.texi: Signal new Babel language

  * lisp/ob-sed.el:
  * testing/examples/ob-sed-test.org:
  * testing/lisp/test-ob-sed.el: New files.

> -@item GNU Screen @tab screen @tab shell @tab sh 
> -@item SQL @tab sql @tab SQLite @tab sqlite
> +@item GNU Screen @tab screen Sed @tab sed
> +@item @tab shell @tab sh @item SQL @tab sql
> +@item @tab SQLite @tab sqlite @tab @tab

This looks wrong. I think it should be:

  @item GNU Screen @tab screen @tab Sed @tab sed
  @item shell @tab sh @tab SQL @tab sql
  @item SQLite @tab sqlite @tab @tab

> +;;; Usage:
> +
> +;; Add to your Emacs config:
> +
> +;; (org-babel-do-load-languages
> +;;  'org-babel-load-languages
> +;;  '((sed . t)))

You may want to introduce usage for :cmd-line and :in-file arguments in
"Usage" section.

> +(defconst org-babel-header-args:sed
> +  '((:cmd-line :any
> +     :in-file  :any))
> +  "Sed specific header arguments.")

It should be

  '((:cmd-line . :any)
    (:in-file  . :any))

See, for example `org-babel-header-args:R'

> +(defun org-babel-execute:sed (body params)
> +  "Execute a block of sed code with Org Babel.
> +BODY is the source inside a sed source block and PARAMS is an
> +association list over the source block configurations. This
                                                        ^^^
                                                     two spaces


Regards,