emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-refile-get-target offers default candidate in duplicity [9.2.6 (9.2.6-4-ge30905-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20191007/)]
Date: Fri, 14 Feb 2020 12:33:11 -0300	[thread overview]
Message-ID: <871rqxyyiw.fsf@gmail.com> (raw)
In-Reply-To: <87h7zttrjo.fsf@bzg.fr>

Hi Bastien,

On Fri, Feb 14 2020, Bastien wrote:

> I've revisited org-refile-get-location given your new information on
> ivy-completing-read but I'm not able to see something wrong in the
> current implementation of org-refile-get-location.  At the same time,
> I don't see why ivy-completing-read would handle arguments differently
> than completing-read-default, so _perhaps_ org-refile-get-location
> still does something wrong.
> If you - or other ivy users - have time to investigate and report,
> please do so.

As I said before, there is much that eludes me in 
'org-refile-get-location', but I'm trying to pin this down further by 
getting some inspection points and trying at least to grasp where it 

In particular, I set one inspection point exactly after the 
completing-read function is called to store the value of local variable 
"answ" which is the return value of the completing-read function. That 
is, right after:

#+begin_src emacs-lisp
(setq answ (funcall cfunc prompt tbl nil (not new-nodes)
			nil 'org-refile-history
			(or cdef (concat (car org-refile-history) 

The value of "answ" right after this step is then:
- with 'ivy-mode' off, that is with 'completing-read-default' as 
  'completing-read-function': "test.org/Top heading 1//" (that is with a 
  *double trailing slash*).
- with 'ivy-mode' on, that is with 'ivy-completing-read' as 
  'completing-read-function': "test.org/Top heading 2/"

In both cases the last trailing slash seems (as far as I understand it) 
to be then trimmed off by 'org-refile--get-location' with:

#+begin_src emacs-lisp
(replace-regexp-in-string "/$" "" refloc)

Why 'ivy-completing-read' does not return the end double slash while 
'completing-read-default' does, I have no idea. But the fact that 
'completing-read-default' returns the refile location with a double 
trailing slash makes me think there is still something to be fixed in 


  parent reply	other threads:[~2020-02-14 15:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 18:34 Bug: org-refile-get-target offers default candidate in duplicity [9.2.6 (9.2.6-4-ge30905-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20191007/)] Gustavo Barros
2020-02-12 23:35 ` Bastien
2020-02-13  1:51   ` Gustavo Barros
2020-02-13  7:45     ` Bastien
2020-02-13 19:44       ` Samuel Wales
2020-02-14 10:02         ` Bastien
2020-02-17  0:06           ` Samuel Wales
2020-02-17  0:14             ` Bastien
2020-02-17  0:17               ` Samuel Wales
2020-02-17  0:25                 ` Samuel Wales
2020-02-17  0:38                   ` Bastien
2020-02-17  1:58                     ` Samuel Wales
2020-02-17 22:55                       ` Bastien
2020-02-17  0:15             ` Samuel Wales
2020-02-13 22:53       ` Gustavo Barros
2020-02-13 23:13         ` Samuel Wales
2020-02-14 10:02         ` Bastien
2020-02-14 13:41           ` Gustavo Barros
2020-02-14 15:29             ` Bastien
2020-02-14 16:37               ` Gustavo Barros
2020-02-14 15:33           ` Gustavo Barros [this message]
2020-02-16 23:22             ` Bastien
2020-02-17  0:45               ` Gustavo Barros
2020-02-17 17:45                 ` Bastien
2020-02-13  2:06   ` Gustavo Barros
2020-02-13  7:19     ` Bastien
2020-02-13 20:51       ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rqxyyiw.fsf@gmail.com \
    --to=gusbrs.2016@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).