emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [ANN] Emergency bugfix release: Org mode 9.6.23
@ 2024-03-24 17:16 Ihor Radchenko
  2024-03-24 17:49 ` Bastien Guerry
  2024-05-06 12:23 ` [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23) Max Nikulin
  0 siblings, 2 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-03-24 17:16 UTC (permalink / raw)
  To: emacs-orgmode, Bastien

Dear all,

I just released Org mode 9.6.23 that fixes several critical
vulnerabilities. The release is coordinated with emergency Emacs 29.3
release
(https://lists.gnu.org/archive/html/info-gnu/2024-03/msg00005.html).

Please upgrade your Org mode *and* Emacs ASAP.

The vulnerabilities involve arbitrary Elisp and LaTeX evaluation when
previewing attachments in Emacs or when opening third-party Org files.

The arbitrary Elisp evaluation is fixed by this release.

The fix for LaTeX evaluation requires Emacs 29.3 and will not work for
the earlier Emacs versions. If upgrading Emacs is not viable, as a
workaround, you can set `org-preview-latex-default-process' to 'verbatim
- this will disable LaTeX previews and avoid the vulnerability.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ANN] Emergency bugfix release: Org mode 9.6.23
  2024-03-24 17:16 [ANN] Emergency bugfix release: Org mode 9.6.23 Ihor Radchenko
@ 2024-03-24 17:49 ` Bastien Guerry
  2024-05-06 12:23 ` [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23) Max Nikulin
  1 sibling, 0 replies; 4+ messages in thread
From: Bastien Guerry @ 2024-03-24 17:49 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

Thanks a lot for your work on this!

-- 
 Bastien Guerry


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23)
  2024-03-24 17:16 [ANN] Emergency bugfix release: Org mode 9.6.23 Ihor Radchenko
  2024-03-24 17:49 ` Bastien Guerry
@ 2024-05-06 12:23 ` Max Nikulin
  2024-05-06 12:58   ` Ihor Radchenko
  1 sibling, 1 reply; 4+ messages in thread
From: Max Nikulin @ 2024-05-06 12:23 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On 25/03/2024 00:16, Ihor Radchenko wrote:
> 
> I just released Org mode 9.6.23 that fixes several critical
> vulnerabilities.

Since a variant of exploit has been published, it is time to add a test 
that might prevent code change re-introducing the most severe vulnerability.

[-- Attachment #2: 0001-test-org-macro.el-Add-test-for-CVE-2024-30202.patch --]
[-- Type: text/x-patch, Size: 1308 bytes --]

From af8cddb44f5ee01fb1c7c9cf664ddbc83c63ac56 Mon Sep 17 00:00:00 2001
From: Max Nikulin <manikulin@gmail.com>
Date: Mon, 6 May 2024 19:04:17 +0700
Subject: [PATCH] test-org-macro.el: Add test for CVE-2024-30202

* testing/lisp/test-org-macro.el (test-org-macro/initialize-templates):
A new test that no code is evaluated when an Org file is opened
(CVE-2024-30202).

Ihor Radchenko [ANN] Emergency bugfix release: Org mode 9.6.23.
Sun, 24 Mar 2024 17:16:50 +0000.
<https://list.orgmode.org/871q7zbldp.fsf@localhost>
---
 testing/lisp/test-org-macro.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/testing/lisp/test-org-macro.el b/testing/lisp/test-org-macro.el
index 3339945fa..88a51693c 100644
--- a/testing/lisp/test-org-macro.el
+++ b/testing/lisp/test-org-macro.el
@@ -22,6 +22,16 @@ ;;; Code:
 \f
 ;;; Macros
 
+(ert-deftest test-org-macro/initialize-templates ()
+  "Test `org-macro-initialize-templates'."
+  ;; No code is executed during loading of Org mode files."
+  (should
+   (org-test-with-temp-text
+       "#+MACRO: title (eval (eval-and-compile (error \"CVE-2024-30202\")))"
+     (progn
+       (org-macro-initialize-templates)
+       t))))
+
 (ert-deftest test-org/macro-replace-all ()
   "Test `org-macro-replace-all' specifications."
   ;; Standard test.
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23)
  2024-05-06 12:23 ` [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23) Max Nikulin
@ 2024-05-06 12:58   ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-05-06 12:58 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Max Nikulin <manikulin@gmail.com> writes:

> On 25/03/2024 00:16, Ihor Radchenko wrote:
>> 
>> I just released Org mode 9.6.23 that fixes several critical
>> vulnerabilities.
>
> Since a variant of exploit has been published, it is time to add a test 
> that might prevent code change re-introducing the most severe vulnerability.
> From af8cddb44f5ee01fb1c7c9cf664ddbc83c63ac56 Mon Sep 17 00:00:00 2001
> From: Max Nikulin <manikulin@gmail.com>
> Date: Mon, 6 May 2024 19:04:17 +0700
> Subject: [PATCH] test-org-macro.el: Add test for CVE-2024-30202

Thanks!
Applied, onto main, after adding another test case with a call to
(org-mode). Just to be sure.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=51aff8a11

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-06 12:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-24 17:16 [ANN] Emergency bugfix release: Org mode 9.6.23 Ihor Radchenko
2024-03-24 17:49 ` Bastien Guerry
2024-05-06 12:23 ` [PATCH] test-org-macro.el: Add test for CVE-2024-30202 (was: Re: [ANN] Emergency bugfix release: Org mode 9.6.23) Max Nikulin
2024-05-06 12:58   ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).