From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [bug?] org-copy-face doesn’t add faces to org-faces customize group
Date: Tue, 23 Sep 2014 20:00:55 +0200 [thread overview]
Message-ID: <86ppemush4.fsf@somewhere.org> (raw)
In-Reply-To: 87y4tant6v.fsf@gmail.com
Hi Aaron,
Aaron Ecay wrote:
> 2014ko irailak 23an, Sebastien Vauban-ek idatzi zuen:
>> Aaron Ecay wrote:
>>> 2014ko abuztuak 29an, Sebastien Vauban-ek idatzi zuen:
>>>> I think it's related to an Emacs bug (#16440) which I reported on the
>>>> Org mailing list in February.
>>>
>>> I don’t completely understand what is going on in that bug report. My
>>> proposal is to convert org-copy-face to defface.
>>
>> I think this is "the right thing" (TM).
>>
>>> I can’t tell if this would fix your problem or not, but if it’s
>>> exclusive to the faces I listed in my previous email the answer is
>>> probably “yes.”
>>
>> From what I can see, yes, the faces which are wrongly displayed (before
>> re-applying the theme) match the ones defined by `org-copy-face'. So,
>> this seems the right way to go.
>
> OK, thanks for the followup. I’m attaching the patch to this email. If
> I don’t hear any further feedback, I’ll commit it to master in a few
> days.
I'd say: commit it now, so that it really gets to a broad audience.
Anyway, would there be problems, they would be very, very limited: face
problems, that's all!
Best regards,
Seb
--
Sebastien Vauban
next prev parent reply other threads:[~2014-09-23 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 1:41 [bug?] org-copy-face doesn’t add faces to org-faces customize group Aaron Ecay
2014-08-29 11:45 ` Sebastien Vauban
2014-08-30 19:03 ` Aaron Ecay
[not found] ` <87wq9pssuo.fsf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-23 9:40 ` Sebastien Vauban
2014-09-23 17:27 ` Aaron Ecay
2014-09-23 18:00 ` Sebastien Vauban [this message]
2014-09-28 3:38 ` Aaron Ecay
2014-09-29 10:06 ` Sebastien Vauban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ppemush4.fsf@somewhere.org \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).