* [PATCH] Fix one remaining emacs-30 byte-compile warning
@ 2023-01-24 9:29 Arash Esbati
2023-01-25 11:58 ` Ihor Radchenko
2023-01-25 13:48 ` Robert Pluim
0 siblings, 2 replies; 10+ messages in thread
From: Arash Esbati @ 2023-01-24 9:29 UTC (permalink / raw)
To: emacs-orgmode
Hi all,
Robert sent a patch[1] which pacifies emacs-30 compiler warning. He
missed one which is fixed by the patch below. It is against org-mode
master (6b15897a56).
Footnotes:
[1] https://lists.gnu.org/archive/html/emacs-orgmode/2023-01/msg00743.html
Best, Arash
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
Optional argument POST-PROCESS is a function which should accept
no argument. It is always called within the current process,
from BUFFER, with point at its beginning. Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,
(defun org-latex-export-as-latex
(&optional async subtreep visible-only body-only ext-plist)
(interactive)
(org-export-to-buffer \\='latex \"*Org LATEX Export*\"
async subtreep visible-only body-only ext-plist
- #'LaTeX-mode))
+ #\\='LaTeX-mode))
When expressed as an anonymous function, using `lambda',
POST-PROCESS needs to be quoted.
--8<---------------cut here---------------end--------------->8---
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] Fix one remaining emacs-30 byte-compile warning
2023-01-24 9:29 [PATCH] Fix one remaining emacs-30 byte-compile warning Arash Esbati
@ 2023-01-25 11:58 ` Ihor Radchenko
2023-01-25 15:45 ` Arash Esbati
2023-01-25 13:48 ` Robert Pluim
1 sibling, 1 reply; 10+ messages in thread
From: Ihor Radchenko @ 2023-01-25 11:58 UTC (permalink / raw)
To: Arash Esbati; +Cc: emacs-orgmode
Arash Esbati <arash@gnu.org> writes:
> Robert sent a patch[1] which pacifies emacs-30 compiler warning. He
> missed one which is fixed by the patch below. It is against org-mode
> master (6b15897a56).
Thanks!
Could you please write a full patch with commit message? See
https://orgmode.org/worg/org-contribute.html#first-patch
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix one remaining emacs-30 byte-compile warning
2023-01-25 11:58 ` Ihor Radchenko
@ 2023-01-25 15:45 ` Arash Esbati
2023-01-26 9:22 ` Ihor Radchenko
0 siblings, 1 reply; 10+ messages in thread
From: Arash Esbati @ 2023-01-25 15:45 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
Ihor Radchenko <yantar92@posteo.net> writes:
> Could you please write a full patch with commit message? See
> https://orgmode.org/worg/org-contribute.html#first-patch
Thanks for your response. I hope I've got it right.
Best, Arash
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-ox.el-Pacify-compiler-warning.patch --]
[-- Type: text/x-patch, Size: 1200 bytes --]
From c550ed05d29cf163c286cffc328e5860423c7cde Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Wed, 25 Jan 2023 16:34:42 +0100
Subject: [PATCH] lisp/ox.el: Pacify compiler warning
* lisp/ox.el (org-export-to-buffer): Escape single quote in the
example given in docstring.
Add missing '.' after the abbreviation.
---
lisp/ox.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
Optional argument POST-PROCESS is a function which should accept
no argument. It is always called within the current process,
from BUFFER, with point at its beginning. Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,
(defun org-latex-export-as-latex
(&optional async subtreep visible-only body-only ext-plist)
(interactive)
(org-export-to-buffer \\='latex \"*Org LATEX Export*\"
async subtreep visible-only body-only ext-plist
- #'LaTeX-mode))
+ #\\='LaTeX-mode))
When expressed as an anonymous function, using `lambda',
POST-PROCESS needs to be quoted.
--
2.39.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Fix one remaining emacs-30 byte-compile warning
2023-01-24 9:29 [PATCH] Fix one remaining emacs-30 byte-compile warning Arash Esbati
2023-01-25 11:58 ` Ihor Radchenko
@ 2023-01-25 13:48 ` Robert Pluim
2023-01-25 15:53 ` Arash Esbati
1 sibling, 1 reply; 10+ messages in thread
From: Robert Pluim @ 2023-01-25 13:48 UTC (permalink / raw)
To: Arash Esbati; +Cc: emacs-orgmode
>>>>> On Tue, 24 Jan 2023 10:29:17 +0100, Arash Esbati <arash@gnu.org> said:
Arash> Hi all,
Arash> Robert sent a patch[1] which pacifies emacs-30 compiler warning. He
Arash> missed one which is fixed by the patch below. It is against org-mode
Arash> master (6b15897a56).
I didnʼt miss it, it was next on my list, since I didnʼt want to mix
different types of fixes in the same commit. Of course my fixes are
incomplete, as Ihor has pointed out, so more work is needed there. 😀
Arash> +use it to set a major mode there, e.g.,
I prefer ':' to ',' in such situations, but I donʼt recall what the
official position is (if there is one).
Robert
--
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] Fix one remaining emacs-30 byte-compile warning
2023-01-25 13:48 ` Robert Pluim
@ 2023-01-25 15:53 ` Arash Esbati
0 siblings, 0 replies; 10+ messages in thread
From: Arash Esbati @ 2023-01-25 15:53 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-orgmode
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 24 Jan 2023 10:29:17 +0100, Arash Esbati <arash@gnu.org> said:
>
> I didnʼt miss it, it was next on my list,
Sorry for my wrong assumption here.
> Of course my fixes are incomplete, as Ihor has pointed out, so more
> work is needed there. 😀
I know why I volunteered for the change I suggested 😉
> Arash> +use it to set a major mode there, e.g.,
>
> I prefer ':' to ',' in such situations, but I donʼt recall what the
> official position is (if there is one).
-> git --no-pager grep "e.g.:$" | wc -l
13
-> git --no-pager grep "e.g.,$" | wc -l
49
':' would have been my preference my well.
Best, Arash
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-03-22 14:37 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-24 9:29 [PATCH] Fix one remaining emacs-30 byte-compile warning Arash Esbati
2023-01-25 11:58 ` Ihor Radchenko
2023-01-25 15:45 ` Arash Esbati
2023-01-26 9:22 ` Ihor Radchenko
2023-01-26 10:43 ` Arash Esbati
2023-01-27 13:01 ` Ihor Radchenko
2023-03-22 14:00 ` Bastien Guerry
2023-03-22 14:38 ` Ihor Radchenko
2023-01-25 13:48 ` Robert Pluim
2023-01-25 15:53 ` Arash Esbati
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).