emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Jérémy Compostella" <jeremy.compostella@gmail.com>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-babel-exp-lob-one-liners should not parse the entire buffer.
Date: Thu, 24 Nov 2011 20:40:37 +0100	[thread overview]
Message-ID: <86ipm9gvgq.fsf@gmail.com> (raw)
In-Reply-To: <81pqgh4bon.fsf@gmail.com> (Jambunathan K.'s message of "Thu, 24 Nov 2011 23:58:40 +0530")

Jambunathan K <kjambunathan@gmail.com> writes:
>> All,
>>
>> I'm currently generating a road book for a trip from different Org-Mode
>> file and other data. It results in a 13 thousands lines Org-Mode file
>> and I have some performance issues. Using the ELP package, I isolated
>> the two main bottlenecks.
>>
>> 1. One is in org-odt : the org-odt-write-manifest-file function is
>>    called once and takes 5.546672 seconds to write a 167 lines file. I
>>    rewrote this function and now it takes 0.01606 seconds to write the
>>    same file. As usually for this package, I directly send the patch to
>>    the org-odt author.
>
> I think it is multiple write-region that takes the toll.
I do agree.

> I have pushed a variation of your original fix which minimizes the
> number of lines originally modified by you.
>
> I have acknowledged you as the author in the commit message (even though
> I appear as the author)
Fine.

>> As usually for this package, I directly send the patch to the org-odt
>> author.
>
> Btw, you can post your patches to the list. I am a regular on this list.
OK.
> Jambunathan K.

What about the second patch ? I'm very interested in seeing it merged. 

Jeremy
-- 
Sent from my Emacs

  reply	other threads:[~2011-11-24 19:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24 15:56 [PATCH] org-babel-exp-lob-one-liners should not parse the entire buffer Jérémy Compostella
2011-11-24 18:28 ` Jambunathan K
2011-11-24 19:40   ` Jérémy Compostella [this message]
2011-11-24 20:21     ` [odt] [PATCH] Anchoring image to a page Jambunathan K
2011-11-24 21:31       ` Jérémy Compostella
2011-12-26 11:01         ` Jambunathan K
2011-11-25 16:33 ` [PATCH] org-babel-exp-lob-one-liners should not parse the entire buffer Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ipm9gvgq.fsf@gmail.com \
    --to=jeremy.compostella@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kjambunathan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).