From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?J=C3=A9r=C3=A9my_Compostella?= Subject: Re: [PATCH] org-babel-exp-lob-one-liners should not parse the entire buffer. Date: Thu, 24 Nov 2011 20:40:37 +0100 Message-ID: <86ipm9gvgq.fsf@gmail.com> References: <81pqgh4bon.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:55437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTfA3-0006tV-UF for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 14:40:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RTfA2-0003HI-Kx for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 14:40:43 -0500 Received: from mail-fx0-f41.google.com ([209.85.161.41]:36443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RTfA2-0003HB-GX for emacs-orgmode@gnu.org; Thu, 24 Nov 2011 14:40:42 -0500 Received: by faas10 with SMTP id s10so3807557faa.0 for ; Thu, 24 Nov 2011 11:40:41 -0800 (PST) In-Reply-To: <81pqgh4bon.fsf@gmail.com> (Jambunathan K.'s message of "Thu, 24 Nov 2011 23:58:40 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: emacs-orgmode@gnu.org Jambunathan K writes: >> All, >> >> I'm currently generating a road book for a trip from different Org-Mode >> file and other data. It results in a 13 thousands lines Org-Mode file >> and I have some performance issues. Using the ELP package, I isolated >> the two main bottlenecks. >> >> 1. One is in org-odt : the org-odt-write-manifest-file function is >> called once and takes 5.546672 seconds to write a 167 lines file. I >> rewrote this function and now it takes 0.01606 seconds to write the >> same file. As usually for this package, I directly send the patch to >> the org-odt author. > > I think it is multiple write-region that takes the toll. I do agree. > I have pushed a variation of your original fix which minimizes the > number of lines originally modified by you. > > I have acknowledged you as the author in the commit message (even though > I appear as the author) Fine. >> As usually for this package, I directly send the patch to the org-odt >> author. > > Btw, you can post your patches to the list. I am a regular on this list. OK. > Jambunathan K. What about the second patch ? I'm very interested in seeing it merged. Jeremy -- Sent from my Emacs