From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: Nicolas Goaziou <mail-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
Cc: public-emacs-orgmode-mXXj517/zsQ-wOFGN7rlS/M9smdsby/KFg@public.gmane.org
Subject: Re: 63 failures for org-test-run-all-tests in an Emacs GUI
Date: Fri, 30 Jan 2015 15:09:47 +0100 [thread overview]
Message-ID: <86iofoz7f8.fsf@example.com> (raw)
In-Reply-To: <87ppa584wz.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org> (Nicolas Goaziou's message of "Sat, 24 Jan 2015 00:15:40 +0100")
Nicolas Goaziou wrote:
> Sebastien Vauban writes:
>
>> Here is a patch you can apply with no problem -- just checked it on
>> a fresh copy of master.
>
> Thanks.
>
> I can apply it but it introduces test failures.
>
> FAILED ob-shell/generic-uses-no-arrays
> FAILED ob-shell/generic-uses-no-assoc-arrays
> FAILED ob-tangle/continued-code-blocks-w-noweb-ref
> FAILED test-ob/specific-colnames
>
> Could you look into it?
I only see 3 problems right now (not `test-ob/specific-colnames'
anymore!?).
Regarding `ob-tangle/continued-code-blocks-w-noweb-ref', it's because
some `babel.shell' is now created (from a tangle operation) and is
inserted in the test in question:
┌────
│ (ert-deftest ob-tangle/continued-code-blocks-w-noweb-ref ()
│ "Test that the :noweb-ref header argument is used correctly."
│ (org-test-at-id "54d68d4b-1544-4745-85ab-4f03b3cbd8a0"
│ (let ((tangled
│ "df|sed '1d'|awk '{print $5 \" \" $6}'|sort -n |tail -1|awk '{print $2}'"))
│ (org-narrow-to-subtree)
│ (org-babel-tangle)
│ (with-temp-buffer
│ (insert-file-contents "babel.shell") ; <<<< was babel.sh
│ (goto-char (point-min))
│ (should (re-search-forward (regexp-quote tangled) nil t)))
│ (delete-file "babel.shell")))) ; <<<< was babel.sh
└────
Changing the file extension in the above test makes the problem
disappears, though I'm not sure it's the cleanest way to do it: the
shell block should be tangled to a file with the `sh' extension in the
first place, but why isn't it still the case?
Regarding `ob-shell/generic-uses-no-arrays' and
`ob-shell/generic-uses-no-assoc-arrays', they both make use of the code
block defined in the file `testing/examples/ob-shell-test.org':
┌────
│ * Array tests
│ :PROPERTIES:
│ :ID: 0ba56632-8dc1-405c-a083-c204bae477cf
│ :END:
│ ** Generic shell: no arrays
│ #+begin_src shell :exports results :var array=sample_array
│ # ^^^ was sh only
│ echo ${array}
│ #+end_src
└────
Still, I don't understand what's wrong in the tests, for example here
in `ob-shell/generic-uses-no-arrays':
┌────
│ ; A list of tests using the samples in ob-shell-test.org
│ (ert-deftest ob-shell/generic-uses-no-arrays ()
│ "No arrays for generic"
│ (org-test-at-id "0ba56632-8dc1-405c-a083-c204bae477cf"
│ (org-babel-next-src-block)
│ (should (equal "one two three" (org-babel-execute-src-block)))))
└────
Any hint?
PS- Two tests are defined under the same name:
--8<---------------cut here---------------start------------->8---
./test-ob-shell.el:63:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
./test-ob-shell.el:76:(ert-deftest ob-shell/generic-uses-no-assoc-arrays ()
--8<---------------cut here---------------end--------------->8---
Isn't there any protection mechanism against test name duplicates?
Best regards,
Seb
prev parent reply other threads:[~2015-01-30 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 15:45 63 failures for org-test-run-all-tests in an Emacs GUI Sebastien Vauban
2014-12-24 9:53 ` Nicolas Goaziou
2014-12-24 10:33 ` Sebastien Vauban
2014-12-24 12:39 ` Sebastien Vauban
2014-12-24 16:14 ` Nicolas Goaziou
[not found] ` <87egrp2ffk.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
2014-12-29 16:06 ` [PATCH] Replace `org-ctrl-c-ctrl-c' by `org-babel-execute-maybe' in tests Sebastien Vauban
2014-12-30 8:53 ` Nicolas Goaziou
2014-12-30 11:32 ` Sebastien Vauban
2014-12-30 21:46 ` Nicolas Goaziou
[not found] ` <87y4polsjv.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
2014-12-30 23:34 ` Sebastien Vauban
2015-01-03 10:56 ` Nicolas Goaziou
2015-01-23 15:05 ` Sebastien Vauban
2015-01-23 23:14 ` Nicolas Goaziou
2015-01-30 13:29 ` Sebastien Vauban
2015-01-30 17:30 ` Nicolas Goaziou
2014-12-31 9:25 ` 63 failures for org-test-run-all-tests in an Emacs GUI Sebastien Vauban
2015-01-03 10:57 ` Nicolas Goaziou
2015-01-09 21:01 ` Sebastien Vauban
2015-01-10 10:17 ` Nicolas Goaziou
2015-01-23 15:42 ` Sebastien Vauban
2015-01-23 23:15 ` Nicolas Goaziou
[not found] ` <87ppa584wz.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org>
2015-01-30 14:09 ` Sebastien Vauban [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86iofoz7f8.fsf@example.com \
--to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
--cc=mail-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org \
--cc=public-emacs-orgmode-mXXj517/zsQ-wOFGN7rlS/M9smdsby/KFg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).