From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastien Vauban Subject: Re: 63 failures for org-test-run-all-tests in an Emacs GUI Date: Fri, 30 Jan 2015 15:09:47 +0100 Message-ID: <86iofoz7f8.fsf@example.com> References: <86zjaf7knu.fsf@example.com> <87ioh12x25.fsf@nicolasgoaziou.fr> <86bnmk892t.fsf@example.com> <87wq546sjd.fsf@nicolasgoaziou.fr> <86a91rbrde.fsf@example.com> <87387jey7m.fsf@nicolasgoaziou.fr> <86a919mrky.fsf@example.com> <87ppa584wz.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <87ppa584wz.fsf-Gpy5sJQTEQHwkn9pgDnJRVAUjnlXr6A1@public.gmane.org> (Nicolas Goaziou's message of "Sat, 24 Jan 2015 00:15:40 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org To: Nicolas Goaziou Cc: public-emacs-orgmode-mXXj517/zsQ-wOFGN7rlS/M9smdsby/KFg@public.gmane.org Nicolas Goaziou wrote: > Sebastien Vauban writes: > >> Here is a patch you can apply with no problem -- just checked it on >> a fresh copy of master. > > Thanks. > > I can apply it but it introduces test failures. > > FAILED ob-shell/generic-uses-no-arrays > FAILED ob-shell/generic-uses-no-assoc-arrays > FAILED ob-tangle/continued-code-blocks-w-noweb-ref > FAILED test-ob/specific-colnames > > Could you look into it? I only see 3 problems right now (not `test-ob/specific-colnames' anymore!?). Regarding `ob-tangle/continued-code-blocks-w-noweb-ref', it's because some `babel.shell' is now created (from a tangle operation) and is inserted in the test in question: =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 (ert-deftest ob-tangle/continued-code-blocks-w-noweb-ref () =E2=94=82 "Test that the :noweb-ref header argument is used correctly." =E2=94=82 (org-test-at-id "54d68d4b-1544-4745-85ab-4f03b3cbd8a0" =E2=94=82 (let ((tangled =E2=94=82 "df|sed '1d'|awk '{print $5 \" \" $6}'|sort -n |tail -1|awk= '{print $2}'")) =E2=94=82 (org-narrow-to-subtree) =E2=94=82 (org-babel-tangle) =E2=94=82 (with-temp-buffer =E2=94=82 (insert-file-contents "babel.shell") ; <<<< was babel.sh =E2=94=82 (goto-char (point-min)) =E2=94=82 (should (re-search-forward (regexp-quote tangled) nil t))) =E2=94=82 (delete-file "babel.shell")))) ; <<<< was babel.sh =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Changing the file extension in the above test makes the problem disappears, though I'm not sure it's the cleanest way to do it: the shell block should be tangled to a file with the `sh' extension in the first place, but why isn't it still the case? Regarding `ob-shell/generic-uses-no-arrays' and `ob-shell/generic-uses-no-assoc-arrays', they both make use of the code block defined in the file `testing/examples/ob-shell-test.org': =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 * Array tests =E2=94=82 :PROPERTIES: =E2=94=82 :ID: 0ba56632-8dc1-405c-a083-c204bae477cf =E2=94=82 :END: =E2=94=82 ** Generic shell: no arrays =E2=94=82 #+begin_src shell :exports results :var array=3Dsample_array =E2=94=82 # ^^^ was sh only =E2=94=82 echo ${array} =E2=94=82 #+end_src =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Still, I don't understand what's wrong in the tests, for example here in `ob-shell/generic-uses-no-arrays': =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80 =E2=94=82 ; A list of tests using the samples in ob-shell-test.org =E2=94=82 (ert-deftest ob-shell/generic-uses-no-arrays () =E2=94=82 "No arrays for generic" =E2=94=82 (org-test-at-id "0ba56632-8dc1-405c-a083-c204bae477cf" =E2=94=82 (org-babel-next-src-block) =E2=94=82 (should (equal "one two three" (org-babel-execute-src-block= ))))) =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80 Any hint? PS- Two tests are defined under the same name: --8<---------------cut here---------------start------------->8--- ./test-ob-shell.el:63:(ert-deftest ob-shell/generic-uses-no-assoc-arrays () ./test-ob-shell.el:76:(ert-deftest ob-shell/generic-uses-no-assoc-arrays () --8<---------------cut here---------------end--------------->8--- Isn't there any protection mechanism against test name duplicates? Best regards, Seb