emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: Fix bindings of < and > for calendar scrolling
Date: Tue, 21 Oct 2014 11:27:55 +0200	[thread overview]
Message-ID: <84a94pzs9w.fsf@tm6592.fritz.box> (raw)
In-Reply-To: 864muxzxhr.fsf@example.com

Hello Sebastien,

Sebastien Vauban <sva-news@mygooglest.com>
writes:

> Marco Wahl wrote:
>> Find a fix for the bindings of < and > for calendar scrolling for Emacs
>> 25.  The fix is necessary because Emacs 25 dropped some aliases in the
>> calendar lib, in particular those that have been bound to < and >.
>>
>> diff --git a/lisp/org.el b/lisp/org.el
>> index 2b5603c..7f4be6b 100644
>> --- a/lisp/org.el
>> +++ b/lisp/org.el
>> @@ -16285,10 +16285,10 @@ So these are more for recording a certain time/date."
>>                    (message "")))
>>      (org-defkey map ">"
>>                  (lambda () (interactive)
>> -                  (org-eval-in-calendar '(scroll-calendar-left 1))))
>> +                  (org-eval-in-calendar '(calendar-scroll-left 1))))
>
> Can't you simply write                     'calendar-scroll-left ?

No.  This is because org-eval-in-calendar expects a form and not just a
variable.

Your idea to simplyfy the call by dropping the '1' --- i.e. writing
'(calendar-scroll-left) --- sounds good to me.  OTOH there are many
similar lines in org-read-date-minibuffer-local-map which all use the
'1' explicitly.  So I think it would be rather irritating to drop the
'1' in just two locations.


Best regards,  Marco
-- 
http://www.wahlzone.de
GPG: 0x0A3AE6F2

  reply	other threads:[~2014-10-21  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 20:41 [PATCH] org.el: Fix bindings of < and > for calendar scrolling Marco Wahl
2014-10-21  7:35 ` Sebastien Vauban
2014-10-21  9:27   ` Marco Wahl [this message]
2014-10-22 19:12 ` Achim Gratz
2014-10-24  9:17   ` Marco Wahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84a94pzs9w.fsf@tm6592.fritz.box \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).