From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marco Wahl Subject: Re: [PATCH] org.el: Fix bindings of < and > for calendar scrolling Date: Tue, 21 Oct 2014 11:27:55 +0200 Message-ID: <84a94pzs9w.fsf@tm6592.fritz.box> References: <84y4sav5i9.fsf@tm6592.fritz.box> <864muxzxhr.fsf@example.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgVjo-0007xw-VE for emacs-orgmode@gnu.org; Tue, 21 Oct 2014 05:28:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XgVjj-0002q6-Kr for emacs-orgmode@gnu.org; Tue, 21 Oct 2014 05:28:20 -0400 Received: from plane.gmane.org ([80.91.229.3]:47258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XgVjj-0002pq-Es for emacs-orgmode@gnu.org; Tue, 21 Oct 2014 05:28:15 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XgVjb-0007EZ-8Z for emacs-orgmode@gnu.org; Tue, 21 Oct 2014 11:28:07 +0200 Received: from stgt-4d02d4f7.pool.mediaways.net ([77.2.212.247]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Oct 2014 11:28:07 +0200 Received: from marcowahlsoft by stgt-4d02d4f7.pool.mediaways.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 21 Oct 2014 11:28:07 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hello Sebastien, Sebastien Vauban writes: > Marco Wahl wrote: >> Find a fix for the bindings of < and > for calendar scrolling for Emacs >> 25. The fix is necessary because Emacs 25 dropped some aliases in the >> calendar lib, in particular those that have been bound to < and >. >> >> diff --git a/lisp/org.el b/lisp/org.el >> index 2b5603c..7f4be6b 100644 >> --- a/lisp/org.el >> +++ b/lisp/org.el >> @@ -16285,10 +16285,10 @@ So these are more for recording a certain time/date." >> (message ""))) >> (org-defkey map ">" >> (lambda () (interactive) >> - (org-eval-in-calendar '(scroll-calendar-left 1)))) >> + (org-eval-in-calendar '(calendar-scroll-left 1)))) > > Can't you simply write 'calendar-scroll-left ? No. This is because org-eval-in-calendar expects a form and not just a variable. Your idea to simplyfy the call by dropping the '1' --- i.e. writing '(calendar-scroll-left) --- sounds good to me. OTOH there are many similar lines in org-read-date-minibuffer-local-map which all use the '1' explicitly. So I think it would be rather irritating to drop the '1' in just two locations. Best regards, Marco -- http://www.wahlzone.de GPG: 0x0A3AE6F2