emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil
       [not found] <CAFyQvY2wDyjxyN+LxW0OmFPoSXOjTsGxCQTHrw83LppWJ4YNzg@mail.gmail.com>
@ 2022-05-10  2:27 ` Eli Zaretskii
  2022-05-10  4:52   ` Ihor Radchenko
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2022-05-10  2:27 UTC (permalink / raw)
  To: Kaushal Modi; +Cc: 55342

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Mon, 9 May 2022 17:41:32 -0400
> 
> Exporting an Org file with citations on Emacs 29 now throws the error
> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
> the Org version shipped with Emacs on the master branch.

Shouldn't this be reported to Org developers first?

Thanks.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil
  2022-05-10  2:27 ` bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil Eli Zaretskii
@ 2022-05-10  4:52   ` Ihor Radchenko
  2022-05-10  5:06     ` Lars Ingebrigtsen
  2022-05-10 12:08     ` Eli Zaretskii
  0 siblings, 2 replies; 5+ messages in thread
From: Ihor Radchenko @ 2022-05-10  4:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 55342, Kaushal Modi

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Kaushal Modi <kaushal.modi@gmail.com>
>> Date: Mon, 9 May 2022 17:41:32 -0400
>> 
>> Exporting an Org file with citations on Emacs 29 now throws the error
>> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
>> the Org version shipped with Emacs on the master branch.
>
> Shouldn't this be reported to Org developers first?

It has been.
However, part of the problem lies in the bibtex-map-entries:

          ;; If we have invalid entries, ensure that we have forward
          ;; progress so that we don't infloop.
          (if (= (point) prev)
              (forward-line 1)

The code above always skips a bibtex entry starting at bob.
Hence, the provided example bibliography is parsed as empty, which is
not expected by Org.

While handling empty bibfiles should be fixed on Org side, the current
behaviour of bibtex-map-entries should indeed be fixed on Emacs side.

Best,
Ihor




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil
  2022-05-10  4:52   ` Ihor Radchenko
@ 2022-05-10  5:06     ` Lars Ingebrigtsen
  2022-05-10 15:08       ` Kaushal Modi
  2022-05-10 12:08     ` Eli Zaretskii
  1 sibling, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-10  5:06 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Eli Zaretskii, 55342, Kaushal Modi

Ihor Radchenko <yantar92@gmail.com> writes:

> The code above always skips a bibtex entry starting at bob.
> Hence, the provided example bibliography is parsed as empty, which is
> not expected by Org.

This should now be fixed on the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil
  2022-05-10  4:52   ` Ihor Radchenko
  2022-05-10  5:06     ` Lars Ingebrigtsen
@ 2022-05-10 12:08     ` Eli Zaretskii
  1 sibling, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2022-05-10 12:08 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: 55342, kaushal.modi

> From: Ihor Radchenko <yantar92@gmail.com>
> Cc: Kaushal Modi <kaushal.modi@gmail.com>,  55342@debbugs.gnu.org
> Date: Tue, 10 May 2022 12:52:52 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Kaushal Modi <kaushal.modi@gmail.com>
> >> Date: Mon, 9 May 2022 17:41:32 -0400
> >> 
> >> Exporting an Org file with citations on Emacs 29 now throws the error
> >> "Wrong value for ENTRY-OR-KEY: nil". This error can be reproduced with
> >> the Org version shipped with Emacs on the master branch.
> >
> > Shouldn't this be reported to Org developers first?
> 
> It has been.
> However, part of the problem lies in the bibtex-map-entries:
> 
>           ;; If we have invalid entries, ensure that we have forward
>           ;; progress so that we don't infloop.
>           (if (= (point) prev)
>               (forward-line 1)
> 
> The code above always skips a bibtex entry starting at bob.
> Hence, the provided example bibliography is parsed as empty, which is
> not expected by Org.

Thanks.  It would be nice to have that information included in the
original report.




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil
  2022-05-10  5:06     ` Lars Ingebrigtsen
@ 2022-05-10 15:08       ` Kaushal Modi
  0 siblings, 0 replies; 5+ messages in thread
From: Kaushal Modi @ 2022-05-10 15:08 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Eli Zaretskii, 55342, Ihor Radchenko

done 55342

On Tue, May 10, 2022 at 1:06 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
> > The code above always skips a bibtex entry starting at bob.
> > Hence, the provided example bibliography is parsed as empty, which is
> > not expected by Org.
>
> This should now be fixed on the trunk.

Thanks! I confirm the fix.




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-10 15:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAFyQvY2wDyjxyN+LxW0OmFPoSXOjTsGxCQTHrw83LppWJ4YNzg@mail.gmail.com>
2022-05-10  2:27 ` bug#55342: 29.0.50; org-cite-basic--get-field: Wrong value for ENTRY-OR-KEY: nil Eli Zaretskii
2022-05-10  4:52   ` Ihor Radchenko
2022-05-10  5:06     ` Lars Ingebrigtsen
2022-05-10 15:08       ` Kaushal Modi
2022-05-10 12:08     ` Eli Zaretskii

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).