emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* possible bug of display time-range appt in agenda
@ 2007-09-24  6:47 Levin
  2007-09-25 16:12 ` Carsten Dominik
  0 siblings, 1 reply; 2+ messages in thread
From: Levin @ 2007-09-24  6:47 UTC (permalink / raw)
  To: emacs-orgmode

Put something in the org buffer:
** Do something <2007-10-01 11:30-12:20>

then in the agenda, only "Do something" is displayed, without showing the appt 
time.

I trace the code and find out that: 
 (org-get-time-of-day "<2007-10-01 11:30-12:20>")
which return nil cause this probem.

I do not know if this bug has been mentioned or resolved. I'm posting here in 
case that it is not :)

-Levin

PS. I did a patch, which solves the problem. Yet it is a bit ugly :)

(It is the diff of org-get-time-of-day function. line number may be wrong.)
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -19113,9 +19113,9 @@ HH:MM."
     (when
      (or
       (string-match
-       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)\\([AaPp][Mm]\\)?\\> *" s)
+       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)\\([AaPp][Mm]\\)? *" s)
       (string-match
-       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)?\\([AaPp][Mm]\\)\\> *" 
s))
+       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)?\\([AaPp][Mm]\\) *" s))
      (let* ((h (string-to-number (match-string 1 s)))
 	    (m (if (match-end 3) (string-to-number (match-string 3 s)) 0))
 	    (ampm (if (match-end 4) (downcase (match-string 4 s))))

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: possible bug of display time-range appt in agenda
  2007-09-24  6:47 possible bug of display time-range appt in agenda Levin
@ 2007-09-25 16:12 ` Carsten Dominik
  0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2007-09-25 16:12 UTC (permalink / raw)
  To: Levin; +Cc: emacs-orgmode

What version of org-mode are you using?

   (org-get-time-of-day "<2007-10-01 11:30-12:20>")

does return 11:30 for me.

- Carsten

On Sep 23, 2007, at 23:47, Levin wrote:

> Put something in the org buffer:
> ** Do something <2007-10-01 11:30-12:20>
>
> then in the agenda, only "Do something" is displayed, without showing 
> the appt
> time.
>
> I trace the code and find out that:
>  (org-get-time-of-day "<2007-10-01 11:30-12:20>")
> which return nil cause this probem.
>
> I do not know if this bug has been mentioned or resolved. I'm posting 
> here in
> case that it is not :)
>
> -Levin
>
> PS. I did a patch, which solves the problem. Yet it is a bit ugly :)
>
> (It is the diff of org-get-time-of-day function. line number may be 
> wrong.)
> --- a/lisp/org/org.el
> +++ b/lisp/org/org.el
> @@ -19113,9 +19113,9 @@ HH:MM."
>      (when
>       (or
>        (string-match
> -       
> "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)\\([AaPp][Mm]\\)?\\> *" s)
> +       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)\\([AaPp][Mm]\\)? 
> *" s)
>        (string-match
> -       
> "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)?\\([AaPp][Mm]\\)\\> *"
> s))
> +       "\\<\\([012]?[0-9]\\)\\(:\\([0-5][0-9]\\)\\)?\\([AaPp][Mm]\\) 
> *" s))
>       (let* ((h (string-to-number (match-string 1 s)))
>  	    (m (if (match-end 3) (string-to-number (match-string 3 s)) 0))
>  	    (ampm (if (match-end 4) (downcase (match-string 4 s))))
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>

--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-09-25 16:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-24  6:47 possible bug of display time-range appt in agenda Levin
2007-09-25 16:12 ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).