From: Max Nikulin <manikulin@gmail.com>
To: Morgan Willcock <morgan@ice9.digital>
Cc: Martin Marshall <law@martinmarshall.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)]
Date: Tue, 19 Mar 2024 17:21:51 +0700 [thread overview]
Message-ID: <7b676235-5e0d-4b7e-b9bf-5eef0908577c@gmail.com> (raw)
In-Reply-To: <86y1bsowio.fsf@ice9.digital>
On 11/02/2024 04:10, Morgan Willcock wrote:
>
> The shell expansion should work if the asterisk is outside of the
> quotes. I've attached an (untested) patch to explain what I mean.
Never try to quote arbitrary strings by double or single quotes in
shell. There are enough fancy characters that may be interpreted in a
special way. The safest approach is to use `process-file' instead of
`shell-command', but in the case of a remote file shell is unavoidable
and would require additional round trip for `file-expand-wildcards'.
The committed change is anyway incomplete.
> +++ b/lisp/org-ctags.el
> @@ -484,11 +484,11 @@ defun org-ctags-create-tags
> (setq exitcode
> (shell-command
> (format (concat "%s --langdef=orgmode --langmap=orgmode:.org "
> - "--regex-orgmode=\"%s\" -f \"%s\" -e -R %s")
> + "--regex-orgmode=\"%s\" -f \"%s\" -e -R \"%s\"*")
-----------------------------------------------------------^^^^^^
These quote characters should be removed as well
> org-ctags-path-to-ctags
> org-ctags-tag-regexp
> (expand-file-name (concat dir-name "/TAGS"))
It requires `shell-quote-argument' as well
> - (expand-file-name (concat dir-name "/*")))))
> + (expand-file-name (concat dir-name "/")))))
> (cond
> ((eql 0 exitcode)
> (setq-local org-ctags-tag-list
next prev parent reply other threads:[~2024-03-19 10:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 23:57 [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)] Martin Marshall
2024-02-10 4:49 ` Is there something people use instead of org-ctags? (was: [PATCH] `org-ctags-create-tags` creates empty TAGS file) Martin Marshall
2024-02-10 14:29 ` Ihor Radchenko
2024-02-10 14:27 ` [PATCH] `org-ctags-create-tags` creates empty TAGS file [9.6.15 (release_9.6.15 @ /home/martin/Projects/emacs/lisp/org/)] Ihor Radchenko
2024-02-10 21:10 ` Morgan Willcock
2024-02-10 21:20 ` Ihor Radchenko
2024-03-19 10:21 ` Max Nikulin [this message]
2024-03-20 12:08 ` Ihor Radchenko
2024-04-28 7:37 ` [PATCH] org-ctags.el: Protect shell specials in directory name Max Nikulin
2024-04-28 12:53 ` Ihor Radchenko
2024-04-28 16:51 ` Max Nikulin
2024-04-28 16:55 ` Ihor Radchenko
2024-04-28 16:58 ` Max Nikulin
2024-04-28 17:02 ` Ihor Radchenko
2024-04-29 10:26 ` Max Nikulin
2024-04-29 13:12 ` Ihor Radchenko
2024-04-29 16:54 ` [PATCH] org-ctags.el: Do not activate on load Max Nikulin
2024-04-30 10:02 ` Ihor Radchenko
2024-04-30 11:20 ` [PATCH] org.el: Call EXT-enable for `org-modules' (was Re: [PATCH] org-ctags.el: Do not activate on load) Max Nikulin
2024-05-01 10:21 ` Ihor Radchenko
2024-05-01 11:38 ` Max Nikulin
2024-05-01 13:57 ` Ihor Radchenko
2024-04-30 12:59 ` [PATCH] org-ctags.el: Do not activate on load Ihor Radchenko
2024-04-30 13:37 ` Max Nikulin
2024-04-30 15:31 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b676235-5e0d-4b7e-b9bf-5eef0908577c@gmail.com \
--to=manikulin@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=law@martinmarshall.com \
--cc=morgan@ice9.digital \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).