emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
To: Jacopo De Simoi <jacopods@protonmail.com>,
	Org-mode Org-Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Do not throw error when parameter of :tangle is not a string
Date: Thu,  8 Jul 2021 08:44:26 +0000	[thread overview]
Message-ID: <7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu> (raw)
In-Reply-To: <7267271.EvYhyI6sBW@bl4ckspoons>

Hi,

Jacopo De Simoi writes:
>   in the current master branch, if the parameter :tangle of a src block is not
> a string, tangling fails by throwing  an error when calling `file-name-
> directory'  This patch checks if the parameter is a string before calling
> `file-name-directory'.
>
> This makes construct such as :tangle (when condition-applies "filename") work
> again (as they did a few versions ago…)
Thanks for the patch. It looks good to me (had to run `dos2unix' to apply).

To clarify, it fixes `:tangle (when condition-applies "filename")' when the
condition doesn't apply, such as `(when nil "filename")'.

Regards,

-- 
Sébastien Miquel



  reply	other threads:[~2021-07-08  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  4:01 [PATCH} " Jacopo De Simoi
2021-07-08  8:44 ` Sébastien Miquel [this message]
2021-07-08 14:53   ` [PATCH] " Jacopo De Simoi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu \
    --to=sebastien.miquel@posteo.eu \
    --cc=emacs-orgmode@gnu.org \
    --cc=jacopods@protonmail.com \
    --subject='Re: [PATCH] Do not throw error when parameter of :tangle is not a string' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).