emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Jacopo De Simoi <wilderjds@protonmail.com>
To: sebastien.miquel@posteo.eu
Cc: Org-mode Org-Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Do not throw error when parameter of :tangle is not a string
Date: Thu, 08 Jul 2021 14:53:43 +0000	[thread overview]
Message-ID: <acjIYANdb5Np8qpCpzmRruULH1WdW8IGWyHaN6j3-10c-Yb1jztWxkBYaEcu_HJuS9UPeH8hODYnz1T3rHozvY4gH_4mghGiD9ozGnXhRjM=@protonmail.com> (raw)
In-Reply-To: <7a8dc44c-9b27-0ac9-8a88-3faf4d8f60b8@posteo.eu>

Hi Sébastien,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, July 8th, 2021 at 4:44 AM, Sébastien Miquel <sebastien.miquel@posteo.eu> wrote:

> Hi,
>
> Jacopo De Simoi writes:
>
> > in the current master branch, if the parameter :tangle of a src block is not
> >
> > a string, tangling fails by throwing an error when calling `file-name- directory' This patch checks if the parameter is a string before calling` file-name-directory'.
> >
> > This makes construct such as :tangle (when condition-applies "filename") work
> >
> > again (as they did a few versions ago…)
>
> Thanks for the patch. It looks good to me (had to run `dos2unix' to apply).

Dos2unix? I'll make sure it doesn't happen again. It might have to do with having sent the patch from Android.

>To clarify, it fixes` :tangle (when condition-applies "filename")' when the
>
> condition doesn't apply, such as `(when nil "filename")'.

Yes, I will update the commit message and resubmit. Thanks!
>
> Regards,
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Sébastien Miquel


      reply	other threads:[~2021-07-08 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01  4:01 [PATCH} " Jacopo De Simoi
2021-07-08  8:44 ` [PATCH] " Sébastien Miquel
2021-07-08 14:53   ` Jacopo De Simoi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='acjIYANdb5Np8qpCpzmRruULH1WdW8IGWyHaN6j3-10c-Yb1jztWxkBYaEcu_HJuS9UPeH8hODYnz1T3rHozvY4gH_4mghGiD9ozGnXhRjM=@protonmail.com' \
    --to=wilderjds@protonmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sebastien.miquel@posteo.eu \
    --subject='Re: [PATCH] Do not throw error when parameter of :tangle is not a string' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).