* [PATCH] org-contacts: Use progress-reporter for cache update message
@ 2013-05-04 14:09 Rodney Lorrimar
2013-05-04 16:49 ` Carsten Dominik
0 siblings, 1 reply; 2+ messages in thread
From: Rodney Lorrimar @ 2013-05-04 14:09 UTC (permalink / raw)
To: emacs-orgmode
* contrib/lisp/org-contacts.el (org-contacts-db): Use
`make-progress-reporter' instead of `message' for messages. Also
change the sentence to present progressive tense.
---
contrib/lisp/org-contacts.el | 36 ++++++++++++++++++++----------------
1 file changed, 20 insertions(+), 16 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 84ebc9d..c72e6c0 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -211,22 +211,26 @@ A regexp matching strings of whitespace, `,' and `;'.")
(cdr (org-make-tags-matcher org-contacts-matcher)))
markers result)
(when (org-contacts-db-need-update-p)
- (message "Update Org Contacts Database")
- (dolist (file (org-contacts-files))
- (org-check-agenda-file file)
- (with-current-buffer (org-get-agenda-file-buffer file)
- (unless (eq major-mode 'org-mode)
- (error "File %s is no in `org-mode'" file))
- (org-scan-tags
- '(add-to-list 'markers (set-marker (make-marker) (point)))
- contacts-matcher
- todo-only)))
- (dolist (marker markers result)
- (org-with-point-at marker
- (add-to-list 'result
- (list (org-get-heading t) marker (org-entry-properties marker 'all)))))
- (setf org-contacts-db result
- org-contacts-last-update (current-time)))
+ (let ((progress-reporter
+ (make-progress-reporter "Updating Org Contacts Database..." 0 (length org-contacts-files)))
+ (i 0))
+ (dolist (file (org-contacts-files))
+ (org-check-agenda-file file)
+ (with-current-buffer (org-get-agenda-file-buffer file)
+ (unless (eq major-mode 'org-mode)
+ (error "File %s is no in `org-mode'" file))
+ (org-scan-tags
+ '(add-to-list 'markers (set-marker (make-marker) (point)))
+ contacts-matcher
+ todo-only))
+ (progress-reporter-update progress-reporter (setq i (1+ i))))
+ (dolist (marker markers result)
+ (org-with-point-at marker
+ (add-to-list 'result
+ (list (org-get-heading t) marker (org-entry-properties marker 'all)))))
+ (setf org-contacts-db result
+ org-contacts-last-update (current-time))
+ (progress-reporter-done progress-reporter)))
org-contacts-db))
(defun org-contacts-filter (&optional name-match tags-match)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] org-contacts: Use progress-reporter for cache update message
2013-05-04 14:09 [PATCH] org-contacts: Use progress-reporter for cache update message Rodney Lorrimar
@ 2013-05-04 16:49 ` Carsten Dominik
0 siblings, 0 replies; 2+ messages in thread
From: Carsten Dominik @ 2013-05-04 16:49 UTC (permalink / raw)
To: Rodney Lorrimar; +Cc: emacs-orgmode
Applied, thanks.
- Carsten
On 4.5.2013, at 16:09, Rodney Lorrimar <rodney@rodney.id.au> wrote:
> * contrib/lisp/org-contacts.el (org-contacts-db): Use
> `make-progress-reporter' instead of `message' for messages. Also
> change the sentence to present progressive tense.
> ---
> contrib/lisp/org-contacts.el | 36 ++++++++++++++++++++----------------
> 1 file changed, 20 insertions(+), 16 deletions(-)
>
> diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
> index 84ebc9d..c72e6c0 100644
> --- a/contrib/lisp/org-contacts.el
> +++ b/contrib/lisp/org-contacts.el
> @@ -211,22 +211,26 @@ A regexp matching strings of whitespace, `,' and `;'.")
> (cdr (org-make-tags-matcher org-contacts-matcher)))
> markers result)
> (when (org-contacts-db-need-update-p)
> - (message "Update Org Contacts Database")
> - (dolist (file (org-contacts-files))
> - (org-check-agenda-file file)
> - (with-current-buffer (org-get-agenda-file-buffer file)
> - (unless (eq major-mode 'org-mode)
> - (error "File %s is no in `org-mode'" file))
> - (org-scan-tags
> - '(add-to-list 'markers (set-marker (make-marker) (point)))
> - contacts-matcher
> - todo-only)))
> - (dolist (marker markers result)
> - (org-with-point-at marker
> - (add-to-list 'result
> - (list (org-get-heading t) marker (org-entry-properties marker 'all)))))
> - (setf org-contacts-db result
> - org-contacts-last-update (current-time)))
> + (let ((progress-reporter
> + (make-progress-reporter "Updating Org Contacts Database..." 0 (length org-contacts-files)))
> + (i 0))
> + (dolist (file (org-contacts-files))
> + (org-check-agenda-file file)
> + (with-current-buffer (org-get-agenda-file-buffer file)
> + (unless (eq major-mode 'org-mode)
> + (error "File %s is no in `org-mode'" file))
> + (org-scan-tags
> + '(add-to-list 'markers (set-marker (make-marker) (point)))
> + contacts-matcher
> + todo-only))
> + (progress-reporter-update progress-reporter (setq i (1+ i))))
> + (dolist (marker markers result)
> + (org-with-point-at marker
> + (add-to-list 'result
> + (list (org-get-heading t) marker (org-entry-properties marker 'all)))))
> + (setf org-contacts-db result
> + org-contacts-last-update (current-time))
> + (progress-reporter-done progress-reporter)))
> org-contacts-db))
>
> (defun org-contacts-filter (&optional name-match tags-match)
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-04 16:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-04 14:09 [PATCH] org-contacts: Use progress-reporter for cache update message Rodney Lorrimar
2013-05-04 16:49 ` Carsten Dominik
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).