emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Matthew Lundin <mdl@imapmail.org>
Cc: org-mode List <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Removed unecessary invocations of org-agenda-show.
Date: Mon, 4 Oct 2010 06:22:50 +0200	[thread overview]
Message-ID: <62316513-0AF8-4F39-A770-475C76DFB790@gmail.com> (raw)
In-Reply-To: <878w329v2i.fsf@archdesk.localdomain>


On Sep 16, 2010, at 6:22 AM, Matthew Lundin wrote:

> Hi Carsten,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Sep 13, 2010, at 6:48 PM, Matt Lundin wrote:
>>
>>>
>>> lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to
>>> prevent
>>> disrupting windows and changing point in original buffer.
>>> (org-agenda-set-property): Same
>>> (org-agenda-set-effort): Same
>>> (org-agenda-toggle-archive-tag): Same
>>>
>>> When setting a tag in the agenda, org-mode displays the  
>>> corresponding
>>> entry in the original org buffer by calling org-agenda-show. This  
>>> has
>>> the unwelcome side-effect of disrupting the current window  
>>> arrangement
>>> and changing the position of the point in the original buffer. This
>>> behavior is inconsistent with the that of org-agenda-todo, which  
>>> makes
>>> all its changes "silently."
>>
>> I agree, but I am sure I used to have problems with something
>> which is why this was added.
>> Have you been running this patch for some time already?
>> Without any problems like the agenda jumping to a wrong place in a  
>> org
>> file or so?
>
> I haven't yet encountered any deleterious side effects, but I agree  
> that
> this patch needs further consideration. I will do some additional
> research/testing and return with a report. :)

Hi Matt,

any new about this patch?

Thanks

- Carsten

next prev parent reply	other threads:[~2010-10-04  4:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-13 16:48 [PATCH] Removed unecessary invocations of org-agenda-show Matt Lundin
2010-09-14  7:35 ` Carsten Dominik
2010-09-16  4:22   ` Matthew Lundin
2010-10-04  4:22     ` Carsten Dominik [this message]
2010-10-05 18:07       ` Matt Lundin
2011-05-02  8:17 ` [Accepted] [Orgmode] " Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62316513-0AF8-4F39-A770-475C76DFB790@gmail.com \
    --to=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=mdl@imapmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).