From: Carsten Dominik <cdominik@newartisans.com>
To: emacs-orgmode@gnu.org
Subject: [Accepted] [Orgmode] Removed unecessary invocations of org-agenda-show.
Date: Mon, 2 May 2011 10:17:01 +0200 (CEST) [thread overview]
Message-ID: <20110502081701.6CCF8436F83@u016822.science.uva.nl> (raw)
In-Reply-To: 87zkvly3m3.fsf@archdesk.localdomain
Patch 271 (http://patchwork.newartisans.com/patch/271/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3C87zkvly3m3.fsf%40archdesk.localdomain%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Removed unecessary invocations of org-agenda-show.
> Date: Mon, 13 Sep 2010 20:48:27 -0000
> From: Matt Lundin <mdl@imapmail.org>
> X-Patchwork-Id: 271
> Message-Id: <87zkvly3m3.fsf@archdesk.localdomain>
> To: Org Mode <emacs-orgmode@gnu.org>
>
> lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to prevent
> disrupting windows and changing point in original buffer.
> (org-agenda-set-property): Same
> (org-agenda-set-effort): Same
> (org-agenda-toggle-archive-tag): Same
>
> When setting a tag in the agenda, org-mode displays the corresponding
> entry in the original org buffer by calling org-agenda-show. This has
> the unwelcome side-effect of disrupting the current window arrangement
> and changing the position of the point in the original buffer. This
> behavior is inconsistent with the that of org-agenda-todo, which makes
> all its changes "silently."
>
> Here is the offending line (6799) in org-agenda-set-tags:
>
> --8<---------------cut here---------------start------------->8---
> (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
> --8<---------------cut here---------------end--------------->8---
>
> The same line occurs in org-agenda-set-property, org-agenda-set-effort,
> and org-agenda-toggle-archive tag.
>
> ---
> lisp/org-agenda.el | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 32c65db..784ba6a 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -6796,7 +6796,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
> (org-agenda-check-no-diary)
> (if (and (org-region-active-p) (interactive-p))
> (call-interactively 'org-change-tag-in-region)
> - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
> (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
> (org-agenda-error)))
> (buffer (marker-buffer hdmarker))
> @@ -6825,7 +6824,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
> "Set a property for the current headline."
> (interactive)
> (org-agenda-check-no-diary)
> - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
> (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
> (org-agenda-error)))
> (buffer (marker-buffer hdmarker))
> @@ -6848,7 +6846,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
> "Set the effort property for the current headline."
> (interactive)
> (org-agenda-check-no-diary)
> - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
> (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
> (org-agenda-error)))
> (buffer (marker-buffer hdmarker))
> @@ -6872,7 +6869,6 @@ the same tree node, and the headline of the tree node in the Org-mode file."
> "Toggle the archive tag for the current entry."
> (interactive)
> (org-agenda-check-no-diary)
> - (org-agenda-show) ;;; FIXME This is a stupid hack and should not be needed
> (let* ((hdmarker (or (org-get-at-bol 'org-hd-marker)
> (org-agenda-error)))
> (buffer (marker-buffer hdmarker))
>
prev parent reply other threads:[~2011-05-02 8:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 16:48 [PATCH] Removed unecessary invocations of org-agenda-show Matt Lundin
2010-09-14 7:35 ` Carsten Dominik
2010-09-16 4:22 ` Matthew Lundin
2010-10-04 4:22 ` Carsten Dominik
2010-10-05 18:07 ` Matt Lundin
2011-05-02 8:17 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502081701.6CCF8436F83@u016822.science.uva.nl \
--to=cdominik@newartisans.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).