From: Carsten Dominik <carsten.dominik@gmail.com>
To: Matt Lundin <mdl@imapmail.org>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Revert "Fix :VISIBILITY: handling of nested "folded" properties"
Date: Mon, 6 Dec 2010 10:07:23 +0100 [thread overview]
Message-ID: <614CA58B-9D41-45EB-BB27-0C8EA77991EF@gmail.com> (raw)
In-Reply-To: <871v5v1pd8.fsf@fastmail.fm>
Applied, thanks.
- Carsten
On Dec 6, 2010, at 5:45 AM, Matt Lundin wrote:
> This reverts commit 383802d063a9f2dd959d5574b226fa8ec7f8be41.
>
> The commit had org-mode process the headlines from bottom to top,
> which
> meant that any changes to the visibility of lower headlines were
> overridden/modified by changes higher up the tree. Reverting the
> commit
> causes VISIBILITY to work correctly.
> ---
> lisp/org.el | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/org.el b/lisp/org.el
> index 66514a2..4b39c9c 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -6073,8 +6073,8 @@ With a numeric prefix, show all headlines up
> to that level."
> (interactive)
> (let (org-show-entry-below state)
> (save-excursion
> - (goto-char (point-max))
> - (while (re-search-backward
> + (goto-char (point-min))
> + (while (re-search-forward
> "^[ \t]*:VISIBILITY:[ \t]+\\([a-z]+\\)"
> nil t)
> (setq state (match-string 1))
> --
> 1.7.3.2
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2010-12-06 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 16:04 Two issues with :VISIBILITY: property Cassio Koshikumo
2010-12-06 4:41 ` Matt Lundin
2010-12-07 0:12 ` Cassio Koshikumo
2010-12-07 11:30 ` Matt Lundin
2010-12-09 9:49 ` Carsten Dominik
2010-12-11 3:55 ` Cassio Koshikumo
2010-12-06 4:45 ` [PATCH] Revert "Fix :VISIBILITY: handling of nested "folded" properties" Matt Lundin
2010-12-06 9:07 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=614CA58B-9D41-45EB-BB27-0C8EA77991EF@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mdl@imapmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).