Re: Re: Two issues with :VISIBILITY: property

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Cassio Koshikumo <ckoshikumo@gmail.com>
Cc: Matt Lundin <mdl@imapmail.org>, emacs-orgmode@gnu.org
Subject: Re: Re: Two issues with :VISIBILITY: property
Date: Thu, 9 Dec 2010 10:49:24 +0100	[thread overview]
Message-ID: <55966220-1F73-41E5-B9FA-A6CE1DC959EE@gmail.com> (raw)
In-Reply-To: <AANLkTi=MOAohfuAhGGsev7xWev8iE4BrppPPhWfk4EER@mail.gmail.com>

Hi Cassio,

while I agree that it would be nice to keep the detailed
visibility structure of a tree while moving it, the effort
to implement that is rather large.

Org moves the tree by cutting it out and pasting it back in.

Outline visibility is done using overlays, not text properties.
Overlays are lost when cutting and pasting text.

So what one would have to do is save all the overlays, compute
their relative distance to the tree head, and re-install
them after pasting.  Possible, but an unproportional
effort in my view.

Org settles currently for this:

When a tree is folded entirely, it will be folded after it has
been moved.  When it is not folded entirely, then it will
remain unfolded after the pasting.

I think that this is entirely acceptable, so I don't view
it as a bug.  Desirable - maybe yes, but not
important in my view.

- Carsten

On Dec 7, 2010, at 1:12 AM, Cassio Koshikumo wrote:

> Thanks a lot, Matt! The patch did correct the second issue.
>
> About the first one:
>
>> I cannot replicate this. When I move the headlines, they remain  
>> folded.
>
> It's strange that you cannot replicate this behavior. I got today's
> snapshot and disabled all my customizations to try a vanilla install,
> and it's still there.
>
> Just to make sure we're talking about the same thing: when you move
> the Level 1 tree (the one that has the PROPERTY drawer) it really
> keeps folded? I ask because I noticed that, if I move one of its
> children, everything remains folded. But if I move the parent tree,
> the entire tree gets expanded.
>
> By the way, it doesn't even take a VISIBILITY setting to cause this.  
> Say I have:
>
> * Chapter 1
> Text under Chapter 1.
>
> ** Section A
>  Text under Section A.
>
> * Chapter 2
> Text under Chapter 2.
>
> ** Section B
>  Text under Section B.
>
> Using S-TAB, I go to OVERVIEW:
>
> * Chapter 1...
> * Chapter 2...
>
> Now I place the cursor on "Chapter 1" and press TAB:
>
> * Chapter 1
> Text under Chapter 1.
>
> ** Section A...
>
> * Chapter 2...
>
> Right now, "Section A" remains folded, which is what you'd expect
> (because "Chapter 1" is only showing its children). But, if I move
> "Chapter 1" down, putting it after "Chapter 2", "Section A" gets
> expanded:
>
> * Chapter 2...
>
> * Chapter 1
> Text under Chapter 1.
>
> ** Section A
>  Text under Section A.
>
> This behavior is absolutely consistent here... If you really cannot
> replicate it, I wonder what could be causing it in my installation.
>
> Thanks again for your help and time,
>
> -- 
> Cássio Koshikumo
>
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode