emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Carsten Dominik <dominik@science.uva.nl>
To: James TD Smith <ahktenzero@mohorovi.cc>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Allow storing clock status between emacs sessions.
Date: Wed, 22 Oct 2008 17:23:36 +0200	[thread overview]
Message-ID: <60CAB6A3-82C6-4EA1-8944-FE120A7EA0D2@uva.nl> (raw)
In-Reply-To: <20081022094212.GA33872@yog-sothoth.mohorovi.cc>


On Oct 22, 2008, at 11:42 AM, James TD Smith wrote:

> Hi Carsten,
>
> On 2008-10-22 11:18:59(+0200), Carsten Dominik wrote:
>> this is a non-trivial patch, and  have not yet had the time to look  
>> at
>> it carefully.  And I am too close to the next release 6.10, which  
>> will
>> likely be the final version that will make it into Emacs 23, so I do
>> not feel comfortable to add it now.  After 6.10, good chances, yes.
>>
>> You can help by stress testing it, so that we can find bugs even
>> before we install it.
>
> I've already noticed a few minor problems, and will be posting a  
> revised version
> of the patch soon, so keeping it out of 6.10 is probably best.
>
> If you want, I will split out the patch into three smaller patches;  
> the
> changelog corrections, resuming clocking from an open clock line on  
> clocking in,
> and saving/restoring `org-clock-history' and the running clock. The  
> changelog
> corrections at least ought to make it into 6.10 :).

Did I mess up the ChangeLog again?  Sorry about that, maybe a merge  
problem.  I think git merge does not like the ChangeLog file  
structure....

Yes, please, this patch separately.

- Carsten

  reply	other threads:[~2008-10-22 15:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-19 16:22 [PATCH] Bugfix in org-add-log-setup James TD Smith
2008-10-19 16:22 ` [PATCH] Allow storing clock status between emacs sessions James TD Smith
2008-10-20 15:42   ` Helge Gudmundsen
2008-10-22  8:45     ` Helge Gudmundsen
2008-10-22  9:18       ` Carsten Dominik
2008-10-22  9:25         ` Helge Gudmundsen
2008-10-22  9:42         ` James TD Smith
2008-10-22 15:23           ` Carsten Dominik [this message]
2008-10-23 10:27             ` [PATCH 0/3] Split my clock resume/clock persistence patch James TD Smith
2008-10-23 10:27               ` [PATCH 1/3] Fix some typos and duplication in the ChangeLog James TD Smith
2008-10-23 10:27                 ` [PATCH 2/3] Add clock resuming James TD Smith
2008-10-23 10:27                   ` James TD Smith
2008-10-23 10:28                   ` [PATCH 3/3] Add clock persistence James TD Smith
2008-10-28  7:33                     ` Carsten Dominik
2008-10-28 11:10                       ` Helge Gudmundsen
2008-10-24  4:55                 ` [PATCH 1/3] Fix some typos and duplication in the ChangeLog Carsten Dominik
2008-10-20  5:46 ` [PATCH] Bugfix in org-add-log-setup Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60CAB6A3-82C6-4EA1-8944-FE120A7EA0D2@uva.nl \
    --to=dominik@science.uva.nl \
    --cc=ahktenzero@mohorovi.cc \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).