From: Carsten Dominik <dominik@science.uva.nl>
To: James TD Smith <ahktenzero@mohorovi.cc>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Bugfix in org-add-log-setup.
Date: Mon, 20 Oct 2008 07:46:00 +0200 [thread overview]
Message-ID: <0DFF8BA7-108C-45F2-B2DD-75492BC35787@uva.nl> (raw)
In-Reply-To: <1224433338-16661-1-git-send-email-ahktenzero@mohorovi.cc>
Applied, thanks.
- Carsten
On Oct 19, 2008, at 6:22 PM, James TD Smith wrote:
> ---
> lisp/ChangeLog | 6 ++++++
> lisp/org.el | 3 ++-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/ChangeLog b/lisp/ChangeLog
> index 35ce9c3..ad7c9fe 100755
> --- a/lisp/ChangeLog
> +++ b/lisp/ChangeLog
> @@ -1,3 +1,9 @@
> +2008-10-19 James TD Smith <ahktenzero@mohorovi.cc>
> +
> + * org.el (org-add-log-setup): Bugfix; code to find insertion point
> + after drawers was skipping ahead one line too many, so notes were
> + inserted after the first note instead of before it.
> +
> 2008-10-18 Carsten Dominik <dominik@science.uva.nl>
>
> * org-table.el (orgtbl-to-html): Bind `html-table-tag' for the
> diff --git a/lisp/org.el b/lisp/org.el
> index 9c08ba4..85f138d 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -8407,7 +8407,8 @@ EXTRA is additional text that will be inserted
> into the notes buffer."
> (while (looking-at org-drawer-regexp)
> (goto-char (match-end 0))
> (re-search-forward org-property-end-re (point-max) t)
> - (forward-line))))
> + (forward-line))
> + (forward-line -1)))
> (unless org-log-states-order-reversed
> (and (= (char-after) ?\n) (forward-char 1))
> (org-skip-over-state-notes)
> --
> 1.5.6.5
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2008-10-20 8:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-19 16:22 [PATCH] Bugfix in org-add-log-setup James TD Smith
2008-10-19 16:22 ` [PATCH] Allow storing clock status between emacs sessions James TD Smith
2008-10-20 15:42 ` Helge Gudmundsen
2008-10-22 8:45 ` Helge Gudmundsen
2008-10-22 9:18 ` Carsten Dominik
2008-10-22 9:25 ` Helge Gudmundsen
2008-10-22 9:42 ` James TD Smith
2008-10-22 15:23 ` Carsten Dominik
2008-10-23 10:27 ` [PATCH 0/3] Split my clock resume/clock persistence patch James TD Smith
2008-10-23 10:27 ` [PATCH 1/3] Fix some typos and duplication in the ChangeLog James TD Smith
2008-10-23 10:27 ` [PATCH 2/3] Add clock resuming James TD Smith
2008-10-23 10:27 ` James TD Smith
2008-10-23 10:28 ` [PATCH 3/3] Add clock persistence James TD Smith
2008-10-28 7:33 ` Carsten Dominik
2008-10-28 11:10 ` Helge Gudmundsen
2008-10-24 4:55 ` [PATCH 1/3] Fix some typos and duplication in the ChangeLog Carsten Dominik
2008-10-20 5:46 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DFF8BA7-108C-45F2-B2DD-75492BC35787@uva.nl \
--to=dominik@science.uva.nl \
--cc=ahktenzero@mohorovi.cc \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).