emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: 吴锐扬 <ywwry66@gmail.com>
To: "Berry, Charles" <ccberry@health.ucsd.edu>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>,
	Eric S Fraga <e.fraga@ucl.ac.uk>
Subject: Re: Confusion about org-confirm-babel-evaluate's behavior while exporting lob calls
Date: Wed, 28 Oct 2020 18:29:49 -0700	[thread overview]
Message-ID: <5A8F4FFB-14DD-4577-99B6-EF557074DEC0@gmail.com> (raw)
In-Reply-To: <C66A68C3-9B61-4824-BAFA-4B9473B6D5E8@health.ucsd.edu>

The author explained his motivation for the commit in the mailing list before it got applied:

> That's because lob calls get wrapped internally in an anonymous
> emacs-lisp source block that then feeds through the result from the
> actual call as elisp.  The attached patch should suppress the
> confirmation for the wrapper call.  To the best of my knowledge nothing
> dangerous can happen with that evaluation and all confirmations for the
> call stack down from there have already taken place according to the
> users' setup.

If I understand correctly, executing a lob call would trigger two user confirmations in the past, and this commit was meant to suppress one of the two confirmations. (I may be wrong since I am a fairly new user of org mode.) Now there is no confirmation at all. IMHO, there should be exactly one confirmation ideally.

But you are right, I should just copy the author on this.


> On Oct 28, 2020, at 10:26 AM, Berry, Charles <ccberry@health.ucsd.edu> wrote:
> FWIW, it doesn't seem like an accident. You might ping the author of this commit:
> $ git log -S "(let (org-confirm-babel-evaluate)"
> commit 56bf3d789146fcd3c9f82d875de28c394fe593a0
> Author: Achim Gratz <Stromeko@Stromeko.DE>
> Date:   Wed Apr 10 20:28:31 2013 +0200
>    Babel: avoid superfluous confirmation for internal wrapper
>    * lisp/ob-exp.el (org-babel-exp-results): Suppress user confirmation
>      of the emacs-lisp wrapper execution around a lob call.
>    * lisp/ob-lob.el (org-babel-lob-execute): Suppress user confirmation
>      of the emacs-lisp wrapper execution around a lob call.
> HTH,
> Chuck
>> On Oct 28, 2020, at 4:32 AM, Eric S Fraga <e.fraga@ucl.ac.uk> wrote:
>> On Wednesday, 14 Oct 2020 at 16:18, 吴锐扬 wrote:
>>> I have org-confirm-babel-evaluate set to t by default. With this, I
>>> expect to be queried with the execution of every code block or lob
>>> call. However, this does not happen when exporting lob calls (to latex
>>> for example). Here is an example:
>> Confirmed with fairly recent org from git with
>> org-confirm-babel-evaluate set to t.  Does seem a little strange.  It
>> doesn't bother me much as I don't export org files that I haven't
>> created myself but it does appear to be a hole.
>> -- 
>> : Eric S Fraga via Emacs 28.0.50, Org release_9.4-61-ga88806.dirty

  reply	other threads:[~2020-10-29  1:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 20:18 Confusion about org-confirm-babel-evaluate's behavior while exporting lob calls 吴锐扬
2020-10-27 17:47 ` 吴锐扬
2020-10-28 11:32 ` Eric S Fraga
2020-10-28 17:26   ` Berry, Charles via General discussions about Org-mode.
2020-10-29  1:29     ` 吴锐扬 [this message]
2020-10-29  3:16       ` Kyle Meyer
2020-10-29 17:17         ` Berry, Charles via General discussions about Org-mode.
2020-11-01 23:44         ` Kyle Meyer
2020-11-02  0:41           ` 吴锐扬
2020-10-29 19:05     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A8F4FFB-14DD-4577-99B6-EF557074DEC0@gmail.com \
    --to=ywwry66@gmail.com \
    --cc=ccberry@health.ucsd.edu \
    --cc=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).