emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Berry, Charles" via "General discussions about Org-mode." <emacs-orgmode@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: 吴锐扬 <ywwry66@gmail.com>, "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Confusion about org-confirm-babel-evaluate's behavior while exporting lob calls
Date: Thu, 29 Oct 2020 17:17:16 +0000	[thread overview]
Message-ID: <59B2F97D-FF4A-48B6-B720-FFAEC1696830@health.ucsd.edu> (raw)
In-Reply-To: <87pn51u3fz.fsf@kyleam.com>

Just on a whim, I changed `org-babel-exp-results' by deleting

  (let (org-confirm-babel-evaluate-NOT)

and the matching right parenthesis.

Now I get a single prompt to confirm evaluation using Ruiyang's ECM.


> On Oct 28, 2020, at 8:16 PM, Kyle Meyer <kyle@kyleam.com> wrote:
> 吴锐扬 writes:
>> The author explained his motivation for the commit in the mailing list before it got applied:
>>> That's because lob calls get wrapped internally in an anonymous
>>> emacs-lisp source block that then feeds through the result from the
>>> actual call as elisp.  The attached patch should suppress the
>>> confirmation for the wrapper call.  To the best of my knowledge nothing
>>> dangerous can happen with that evaluation and all confirmations for the
>>> call stack down from there have already taken place according to the
>>> users' setup.
> Just for reference: it looks like that's
>  https://urldefense.com/v3/__https://orgmode.org/list/87k3oaw7jz.fsf@Rainer.invalid__;!!LLK065n_VXAQ!29k-PVwb9XnRUW2w0NBea_sA5uaG3P1Ck0lJ_EyddjelOaIrJGxmvvR28RAyZpjHiQ$ 
>> If I understand correctly, executing a lob call would trigger two user
>> confirmations in the past, and this commit was meant to suppress one
>> of the two confirmations. (I may be wrong since I am a fairly new user
>> of org mode.)
> Thanks for digging.  Indeed, if you go back to the parent of 56bf3d789
> (Babel: avoid superfluous confirmation for internal wrapper,
> 2013-04-10), there are two queries.  On that commit, there is one.
>> Now there is no confirmation at all. IMHO, there should be exactly
>> one confirmation ideally.
> It looks like the query went away with dbb375fdf (Simplify Babel calls
> evaluation, 2016-06-16), which was included in the 9.0 release.  Based
> on a quick glance at that commit, I don't think that was an intentional
> change.
> I won't take a closer look at this until at least this weekend, though.
> I'd be very happy if someone beat me to it.

  reply	other threads:[~2020-10-29 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 20:18 Confusion about org-confirm-babel-evaluate's behavior while exporting lob calls 吴锐扬
2020-10-27 17:47 ` 吴锐扬
2020-10-28 11:32 ` Eric S Fraga
2020-10-28 17:26   ` Berry, Charles via General discussions about Org-mode.
2020-10-29  1:29     ` 吴锐扬
2020-10-29  3:16       ` Kyle Meyer
2020-10-29 17:17         ` Berry, Charles via General discussions about Org-mode. [this message]
2020-11-01 23:44         ` Kyle Meyer
2020-11-02  0:41           ` 吴锐扬
2020-10-29 19:05     ` Achim Gratz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59B2F97D-FF4A-48B6-B720-FFAEC1696830@health.ucsd.edu \
    --to=emacs-orgmode@gnu.org \
    --cc=ccberry@health.ucsd.edu \
    --cc=kyle@kyleam.com \
    --cc=ywwry66@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).