emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Richard <theonewiththeevillook@yahoo.fr>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)]
Date: Thu, 20 Mar 2014 12:13:50 +0100	[thread overview]
Message-ID: <532ACD6E.4060906@yahoo.fr> (raw)
In-Reply-To: <87fvmdyw9a.fsf@bzg.ath.cx>

Le 20/03/2014 11:55, Bastien a écrit :
> Hi Nicolas,
> 
> Nicolas Richard <theonewiththeevillook@yahoo.fr> writes:
> 
>> Here's a patch. I can commit it if you like, but I don't want to do so
>> without some review (it's not as trivial a change as moving the
>> corresponding footnote to the other section).
> 
> I can't apply the patch, either on maint or on master, but by reading
> it carefully it looks good.

> Just add a missing full-stop at the end of the Changelog sentence "in
> its own section.", and perhaps use `C-x 4 a' from within the diff to
> include the section's name in the Changelog too.

Ok, I'll fix that and make sure it can be applied to master (I'm not
sure how I managed to miss that part.)

> PS: I didn't check carefully because I don't use `C' from magit, but
> I assume magit may be wrong in creating Changelogs.  We should report
> this to magit maintainers if this is true.

Indeed there usually is some difference between C (magit) and C-x 4 a. I
will have a look and report it when I get a chance.

-- 
Nico.

  reply	other threads:[~2014-03-20 11:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-06 12:47 preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] Nicolas Richard
2014-03-13 14:26 ` Bastien
2014-03-19 22:22   ` Nicolas Richard
2014-03-20 10:55     ` Bastien
2014-03-20 11:13       ` Nicolas Richard [this message]
2014-03-20 21:56         ` Bastien
2014-03-22 16:15       ` Nicolas Richard
2014-03-22 16:41         ` Bastien
2014-03-22 17:09           ` Nicolas Richard
2014-03-23  8:29             ` Bastien
2014-03-23  9:53               ` Nicolas Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=532ACD6E.4060906@yahoo.fr \
    --to=theonewiththeevillook@yahoo.fr \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).