From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Richard Subject: Re: preview and default class [8.2.5h (release_8.2.5h-677-g55b0a3 @ /home/youngfrog/sourcetrees/org-mode/lisp/)] Date: Thu, 20 Mar 2014 12:13:50 +0100 Message-ID: <532ACD6E.4060906@yahoo.fr> References: <87pplzbijh.fsf@yahoo.fr> <87y50euqc8.fsf@bzg.ath.cx> <87wqfpx1z5.fsf@yahoo.fr> <87fvmdyw9a.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WQav1-0008Fm-EL for emacs-orgmode@gnu.org; Thu, 20 Mar 2014 07:13:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WQauw-0007nv-Pn for emacs-orgmode@gnu.org; Thu, 20 Mar 2014 07:13:51 -0400 In-Reply-To: <87fvmdyw9a.fsf@bzg.ath.cx> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org Le 20/03/2014 11:55, Bastien a écrit : > Hi Nicolas, > > Nicolas Richard writes: > >> Here's a patch. I can commit it if you like, but I don't want to do so >> without some review (it's not as trivial a change as moving the >> corresponding footnote to the other section). > > I can't apply the patch, either on maint or on master, but by reading > it carefully it looks good. > Just add a missing full-stop at the end of the Changelog sentence "in > its own section.", and perhaps use `C-x 4 a' from within the diff to > include the section's name in the Changelog too. Ok, I'll fix that and make sure it can be applied to master (I'm not sure how I managed to miss that part.) > PS: I didn't check carefully because I don't use `C' from magit, but > I assume magit may be wrong in creating Changelogs. We should report > this to magit maintainers if this is true. Indeed there usually is some difference between C (magit) and C-x 4 a. I will have a look and report it when I get a chance. -- Nico.