From: "Robert P. Goldman" <rpgoldman@sift.info>
To: Carsten Dominik <carsten.dominik@gmail.com>,
Org Mode <emacs-orgmode@gnu.org>
Subject: Re: bug with link following --- a (partial) solution
Date: Sun, 29 Aug 2010 18:27:52 -0500 [thread overview]
Message-ID: <4C7AECF8.1020403@sift.info> (raw)
In-Reply-To: <4C7A7E75.2000403@sift.info>
On 8/29/10 Aug 29 -10:36 AM, Robert Goldman wrote:
> I used org-store-link and org-insert-link to make a link in the attached
> document (I distilled it down from a real document). In my org-mode
> (pulled from git this morning), using Aquamacs 2.0 on Mac OSX Snow
> Leopard (10.6), org-mode cannot follow the link I inserted with o-i-l,
> and it pops up a dialog asking if I should add such a link target.
A quick followup:
I had a shot with git blame, and it seems like the only thing that might
have interfered with this search recently is the commit with the SHA1
has starting a84c8a2c
And, indeed, when I comment out the block that was introduced in this
commit (starting at line 9389):
;; ((and (org-mode-p) org-link-search-must-match-exact-headline)
;; (and (equal (string-to-char s) ?*) (setq s (substring s 1)))
;; (goto-char (point-min))
;; (cond
;; ((let (case-fold-search)
;; (re-search-forward (format org-complex-heading-regexp-format
;; (regexp-quote s))
;; nil t))
;; ;; OK, found a match
;; (goto-char (match-beginning 0)))
;; ((and (not org-link-search-inhibit-query)
;; (eq org-link-search-must-match-exact-headline
'query-to-create)
;; (y-or-n-p "No match - create this as a new heading? "))
;; (goto-char (point-max))
;; (or (bolp) (newline))
;; (insert "* " s "\n")
;; (beginning-of-line 0))
;; (t
;; (goto-char pos)
;; (error "No match"))))
...then my link-following works again.
Carsten, could this patch be reverted until it can be fixed?
Best,
r
next prev parent reply other threads:[~2010-08-29 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 15:36 bug with link following Robert Goldman
2010-08-29 23:27 ` Robert P. Goldman [this message]
2010-09-12 12:16 ` Re: bug with link following --- a (partial) solution David Maus
2010-09-13 2:36 ` Robert Goldman
2010-09-15 9:18 ` David Maus
2010-09-22 18:11 ` David Maus
2010-09-22 18:36 ` Robert Goldman
2010-09-22 18:38 ` Robert Goldman
2010-09-22 18:44 ` David Maus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7AECF8.1020403@sift.info \
--to=rpgoldman@sift.info \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).