From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Robert P. Goldman" Subject: Re: bug with link following --- a (partial) solution Date: Sun, 29 Aug 2010 18:27:52 -0500 Message-ID: <4C7AECF8.1020403@sift.info> References: <4C7A7E75.2000403@sift.info> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from [140.186.70.92] (port=60339 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OprI9-0001pI-AO for emacs-orgmode@gnu.org; Sun, 29 Aug 2010 19:28:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OprI8-0004lg-4A for emacs-orgmode@gnu.org; Sun, 29 Aug 2010 19:28:01 -0400 Received: from enchanter.real-time.com ([63.170.91.11]:3301) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OprI7-0004lX-Sr for emacs-orgmode@gnu.org; Sun, 29 Aug 2010 19:28:00 -0400 In-Reply-To: <4C7A7E75.2000403@sift.info> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik , Org Mode On 8/29/10 Aug 29 -10:36 AM, Robert Goldman wrote: > I used org-store-link and org-insert-link to make a link in the attached > document (I distilled it down from a real document). In my org-mode > (pulled from git this morning), using Aquamacs 2.0 on Mac OSX Snow > Leopard (10.6), org-mode cannot follow the link I inserted with o-i-l, > and it pops up a dialog asking if I should add such a link target. A quick followup: I had a shot with git blame, and it seems like the only thing that might have interfered with this search recently is the commit with the SHA1 has starting a84c8a2c And, indeed, when I comment out the block that was introduced in this commit (starting at line 9389): ;; ((and (org-mode-p) org-link-search-must-match-exact-headline) ;; (and (equal (string-to-char s) ?*) (setq s (substring s 1))) ;; (goto-char (point-min)) ;; (cond ;; ((let (case-fold-search) ;; (re-search-forward (format org-complex-heading-regexp-format ;; (regexp-quote s)) ;; nil t)) ;; ;; OK, found a match ;; (goto-char (match-beginning 0))) ;; ((and (not org-link-search-inhibit-query) ;; (eq org-link-search-must-match-exact-headline 'query-to-create) ;; (y-or-n-p "No match - create this as a new heading? ")) ;; (goto-char (point-max)) ;; (or (bolp) (newline)) ;; (insert "* " s "\n") ;; (beginning-of-line 0)) ;; (t ;; (goto-char pos) ;; (error "No match")))) ...then my link-following works again. Carsten, could this patch be reverted until it can be fixed? Best, r