From: Erik Iverson <eriki@ccbr.umn.edu>
To: Martin Pohlack <mp26@os.inf.tu-dresden.de>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: Bug: inline image display not working when org-indent-mode active, follow-up
Date: Thu, 05 Aug 2010 23:56:35 -0500 [thread overview]
Message-ID: <4C5B9603.4020905@ccbr.umn.edu> (raw)
In-Reply-To: <4C5A778E.2020301@os.inf.tu-dresden.de>
On 08/05/2010 03:34 AM, Martin Pohlack wrote:
> Hi,
>
> On 05.08.2010 04:19, Erik Iverson wrote:
>> In the past few weeks, I found that the overlays of inline images in
>> my org-mode
>> files would flash quickly and then be deleted when using
>> org-indent-mode. This
>> also happened when re-running an org-babel source block that generates
>> graphical
>> output, even without org-indent-mode turned on.[1]
>>
>> I believe I've tracked this down to the following patch,
>>
>> http://www.mail-archive.com/emacs-orgmode@gnu.org/msg25738.html
<snip>
> If a functions want to elide trigger the modification hooks it should
> bind: inhibit-modification-hooks.
<snip>
> Could you try to find out the path from where these modifications
> occur, insert a relevant bind there, and see if this helps?
OK, seems like I got it!
Issue 1:
The overlays would disappear when org-indent-mode was turned on.
Solution:
Simply bind inhibit-modification-hooks in org-indent-refresh-section. Do other
functions in org-indent.el need this? Possibly, but it seems like this worked
in my basic testing.
diff --git a/lisp/org-indent.el b/lisp/org-indent.el
index 45865d1..f6b0487 100644
--- a/lisp/org-indent.el
+++ b/lisp/org-indent.el
@@ -251,7 +251,7 @@ Assumes that BEG is at the beginning of a line."
Point is assumed to be at the beginning of a headline."
(interactive)
(when org-indent-mode
- (let (beg end)
+ (let ((beg end) (inhibit-modification-hooks t))
(save-excursion
(when (ignore-errors (org-back-to-heading))
(setq beg (point))
Issue 2:
The overlays would quickly appear, then disappear when running an org-babel
source block that generates graphical output, say, in R.
This was actually tracked down to using pabbrev.el [2] in my org buffers. Ugh.
Since this isn't org related, there's nothing in org to fix, but on the very
small chance someone else ever has their inline images disappearing in org-mode,
and uses pabbrev mode, I fixed it by simply binding inhibit-modification-hooks
in the let block in pabbrev-mark-add-word.
[2] http://homepages.cs.ncl.ac.uk/phillip.lord/download/emacs/pabbrev.el
next prev parent reply other threads:[~2010-08-06 4:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 2:19 Bug: inline image display not working when org-indent-mode active, follow-up Erik Iverson
2010-08-05 8:34 ` Martin Pohlack
2010-08-05 13:00 ` Erik Iverson
2010-08-06 4:56 ` Erik Iverson [this message]
2010-08-06 10:55 ` Carsten Dominik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5B9603.4020905@ccbr.umn.edu \
--to=eriki@ccbr.umn.edu \
--cc=emacs-orgmode@gnu.org \
--cc=mp26@os.inf.tu-dresden.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).