emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug found (but don't know to fix)
@ 2008-05-19 21:59 Wanrong Lin
  2008-05-21 10:26 ` Carsten Dominik
  0 siblings, 1 reply; 5+ messages in thread
From: Wanrong Lin @ 2008-05-19 21:59 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 1781 bytes --]

Hi Carsten:

I have observed that in Windows "org-open-at-point" (bound to RET key in 
my config) does not work on something like this:

file:\\hostname\path

Today I dug a little bit into it, and found the problem is here (in red):

(defun org-open-file (path &optional in-emacs line search)
  "Open the file at PATH.
First, this expands any special file name abbreviations.  Then the
configuration variable `org-file-apps' is checked if it contains an
entry for this file type, and if yes, the corresponding command is launched.
If no application is found, Emacs simply visits the file.
With optional argument IN-EMACS, Emacs will visit the file.
Optional LINE specifies a line to go to, optional SEARCH a string to
search for.  If LINE or SEARCH is given, the file will always be
opened in Emacs.
If the file does not exist, an error is thrown."
  (setq in-emacs (or in-emacs line search))
  (let* ((file (if (equal path "")
           buffer-file-name
         (substitute-in-file-name *(expand-file-name path)*)))

*(expand-file-name path) *replaces all backslashes with forward slashes, 
and later in the same function


    (if search (org-link-search search))))
     ((consp cmd)
      *(eval cmd)*)

Here "cmd" variable is "(w32-shell-execute "open" file)", and 
w32-shell-execute will complain about the file not existing.

When in-emacs is t, everything works fine, as Emacs understand both 
forward and backward slashes.

Also, it works fine on regular file path like this:
 file:c:\path\file.txt

That is because somehow my Windows system is setup (by our IT guys) to 
understand both forward and backward slashes, but that only works on 
regular file paths, not the Windows shared directory paths.

I wonder whether this can get fixed. Thank you very much.

Wanrong


[-- Attachment #1.2: Type: text/html, Size: 2522 bytes --]

[-- Attachment #2: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-05-21 17:55 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-19 21:59 Bug found (but don't know to fix) Wanrong Lin
2008-05-21 10:26 ` Carsten Dominik
2008-05-21 14:25   ` Wanrong Lin
2008-05-21 17:16     ` Carsten Dominik
2008-05-21 17:54       ` Wanrong Lin

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).