From: Carsten Dominik <carsten.dominik@gmail.com>
To: Reimar Finken <finken@theo2.physik.uni-stuttgart.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes
Date: Thu, 1 Oct 2009 20:01:14 +0200 [thread overview]
Message-ID: <459E7170-A5F5-4270-ADFE-FD3C29580428@gmail.com> (raw)
In-Reply-To: <ek3a648lhh.fsf@theo2.physik.uni-stuttgart.de>
Applied, thanks.
- Carsten
On Sep 30, 2009, at 5:56 PM, Reimar Finken wrote:
> [Sorry for the double post, I was too quick with my C-c C-c]
> Clocking in on any task (C-c C-x C-i) and cancelling afterwards (C-c
> C-x
> C-x) results in the following backtrace:
> ,----
> | Debugger entered--Lisp error: (wrong-type-argument markerp org-
> clock-marker)
> | move-marker(org-clock-marker nil)
> | org-clock-cancel()
> | call-interactively(org-clock-cancel nil nil)
> `----
> Culprit are two erroneous quotes in front of org-clock-marker in org-
> clock-el. The patch (output
> of git diff -u on a clean checkout) fixes the problem:
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index e279898..91a4bcb 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -818,8 +818,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (set-buffer (marker-buffer org-clock-marker))
> (goto-char org-clock-marker)
> (delete-region (1- (point-at-bol)) (point-at-eol)))
> - (move-marker 'org-clock-marker nil)
> - (move-marker 'org-clock-hd-marker nil)
> + (move-marker org-clock-marker nil)
> + (move-marker org-clock-hd-marker nil)
> (setq global-mode-string
> (delq 'org-mode-line-string global-mode-string))
> (force-mode-line-update)
>
>
>
>
> Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4)
> of 2009-07-30 on build21
> Package: Org-mode version 6.31 (release_6.31)
>
> current state:
> ==============
> (setq
> org-after-todo-state-change-hook '(org-clock-out-if-current)
> org-export-preprocess-hook '(org-export-blocks-preprocess)
> org-tab-first-hook '(org-hide-block-toggle-maybe)
> org-src-mode-hook '(org-src-mode-configure-edit-buffer)
> org-confirm-shell-link-function 'yes-or-no-p
> org-agenda-before-write-hook '(org-agenda-add-entry-text)
> org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-
> drawers
> org-cycle-show-empty-lines
> org-optimize-window-after-visibility-change)
> org-mode-hook '((lambda nil
> (org-add-hook (quote change-major-mode-hook)
> (quote org-show-block-all) (quote append) (quote local))
> )
> )
> org-confirm-elisp-link-function 'yes-or-no-p
> org-occur-hook '(org-first-headline-recenter)
> )
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
next prev parent reply other threads:[~2009-10-01 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 15:56 Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes Reimar Finken
2009-10-01 18:01 ` Carsten Dominik [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-09-30 15:56 Reimar Finken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459E7170-A5F5-4270-ADFE-FD3C29580428@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=finken@theo2.physik.uni-stuttgart.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).