From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Org-mode version 6.31 (release_6.31); org-clock-cancel erroneous quotes Date: Thu, 1 Oct 2009 20:01:14 +0200 Message-ID: <459E7170-A5F5-4270-ADFE-FD3C29580428@gmail.com> References: Mime-Version: 1.0 (Apple Message framework v936) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MtPy0-0007Wr-Hx for emacs-orgmode@gnu.org; Thu, 01 Oct 2009 14:01:24 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtPxv-0007WR-Th for emacs-orgmode@gnu.org; Thu, 01 Oct 2009 14:01:24 -0400 Received: from [199.232.76.173] (port=46832 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtPxv-0007WO-PZ for emacs-orgmode@gnu.org; Thu, 01 Oct 2009 14:01:19 -0400 Received: from mail-ew0-f208.google.com ([209.85.219.208]:64870) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MtPxv-0008T2-2J for emacs-orgmode@gnu.org; Thu, 01 Oct 2009 14:01:19 -0400 Received: by ewy4 with SMTP id 4so435585ewy.31 for ; Thu, 01 Oct 2009 11:01:18 -0700 (PDT) In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Reimar Finken Cc: emacs-orgmode@gnu.org Applied, thanks. - Carsten On Sep 30, 2009, at 5:56 PM, Reimar Finken wrote: > [Sorry for the double post, I was too quick with my C-c C-c] > Clocking in on any task (C-c C-x C-i) and cancelling afterwards (C-c > C-x > C-x) results in the following backtrace: > ,---- > | Debugger entered--Lisp error: (wrong-type-argument markerp org- > clock-marker) > | move-marker(org-clock-marker nil) > | org-clock-cancel() > | call-interactively(org-clock-cancel nil nil) > `---- > Culprit are two erroneous quotes in front of org-clock-marker in org- > clock-el. The patch (output > of git diff -u on a clean checkout) fixes the problem: > > diff --git a/lisp/org-clock.el b/lisp/org-clock.el > index e279898..91a4bcb 100644 > --- a/lisp/org-clock.el > +++ b/lisp/org-clock.el > @@ -818,8 +818,8 @@ If there is no running clock, throw an error, > unless FAIL-QUIETLY is set." > (set-buffer (marker-buffer org-clock-marker)) > (goto-char org-clock-marker) > (delete-region (1- (point-at-bol)) (point-at-eol))) > - (move-marker 'org-clock-marker nil) > - (move-marker 'org-clock-hd-marker nil) > + (move-marker org-clock-marker nil) > + (move-marker org-clock-hd-marker nil) > (setq global-mode-string > (delq 'org-mode-line-string global-mode-string)) > (force-mode-line-update) > > > > > Emacs : GNU Emacs 23.1.1 (i586-suse-linux-gnu, GTK+ Version 2.14.4) > of 2009-07-30 on build21 > Package: Org-mode version 6.31 (release_6.31) > > current state: > ============== > (setq > org-after-todo-state-change-hook '(org-clock-out-if-current) > org-export-preprocess-hook '(org-export-blocks-preprocess) > org-tab-first-hook '(org-hide-block-toggle-maybe) > org-src-mode-hook '(org-src-mode-configure-edit-buffer) > org-confirm-shell-link-function 'yes-or-no-p > org-agenda-before-write-hook '(org-agenda-add-entry-text) > org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide- > drawers > org-cycle-show-empty-lines > org-optimize-window-after-visibility-change) > org-mode-hook '((lambda nil > (org-add-hook (quote change-major-mode-hook) > (quote org-show-block-all) (quote append) (quote local)) > ) > ) > org-confirm-elisp-link-function 'yes-or-no-p > org-occur-hook '(org-first-headline-recenter) > ) > > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode