From: stardiviner <numbchild@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-src-edit support open edit buffer bellow current window
Date: Sat, 17 Mar 2018 12:26:27 +0800 [thread overview]
Message-ID: <44088bfc-1700-fc0c-7cd7-896ad7d43d1b@gmail.com> (raw)
In-Reply-To: <874llfae0i.fsf@nicolasgoaziou.fr>
[-- Attachment #1.1: Type: text/plain, Size: 368 bytes --]
regenerated patch against HEAD now. Check it out. Thanks for your review.
On 03/17/2018 05:47 AM, Nicolas Goaziou wrote:
> Hello,
>
> stardiviner <numbchild@gmail.com> writes:
>
>> Hi, @Nicolas is this patch still has any thing need to change?
> It doesn't apply on master branch. Could you rebase it against HEAD and
> send it again?
>
> Thank you.
>
> Regards,
>
[-- Attachment #1.2: Type: text/html, Size: 989 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-src.el-org-src-window-setup-support-open-edit-sr.patch --]
[-- Type: text/x-patch; name="0001-org-src.el-org-src-window-setup-support-open-edit-sr.patch", Size: 2137 bytes --]
From fc84014b600afb3eb23fc2e73c359aed5c0791af Mon Sep 17 00:00:00 2001
From: stardiviner <numbchild@gmail.com>
Date: Tue, 13 Mar 2018 01:23:52 +0800
Subject: [PATCH] org-src.el: (org-src-window-setup) support open edit src
window below.
TINYCHANGE
---
etc/ORG-NEWS | 2 ++
lisp/org-src.el | 6 ++++++
2 files changed, 8 insertions(+)
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index 01a9361df..c14bbe1d4 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -113,6 +113,8 @@ now sort according to the locale’s collation rules instead of by
code-point.
** New features
+*** Add support for open src block in below window
+Set option ~org-src-window-setup~ to ~'split-window-below~.
*** Add support for links to LaTeX equations in HTML export
Use MathJax links when enabled (by ~org-html-with-latex~), otherwise
add a label to the rendered equation.
diff --git a/lisp/org-src.el b/lisp/org-src.el
index dfa2ae3de..5d3c2e538 100644
--- a/lisp/org-src.el
+++ b/lisp/org-src.el
@@ -155,6 +155,8 @@ Possible values for this option are:
current-window Show edit buffer in the current window, keeping all other
windows.
+split-window-below Show edit buffer below the current window, keeping all
+ other windows.
other-window Use `switch-to-buffer-other-window' to display edit buffer.
reorganize-frame Show only two windows on the current frame, the current
window and the edit buffer. When exiting the edit buffer,
@@ -164,6 +166,7 @@ other-frame Use `switch-to-buffer-other-frame' to display edit buffer.
:group 'org-edit-structure
:type '(choice
(const current-window)
+ (const split-window-below)
(const other-frame)
(const other-window)
(const reorganize-frame)))
@@ -746,6 +749,9 @@ If BUFFER is non-nil, test it instead."
(`current-window (pop-to-buffer-same-window buffer))
(`other-window
(switch-to-buffer-other-window buffer))
+ (`split-window-below
+ (select-window (split-window-vertically))
+ (pop-to-buffer-same-window buffer))
(`other-frame
(pcase context
(`exit
--
2.16.2
next prev parent reply other threads:[~2018-03-17 4:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 17:27 [PATCH] org-src-edit support open edit buffer bellow current window stardiviner
2018-03-13 8:22 ` Nicolas Goaziou
2018-03-13 10:19 ` stardiviner
2018-03-16 7:27 ` stardiviner
2018-03-16 21:47 ` Nicolas Goaziou
2018-03-17 4:26 ` stardiviner [this message]
2018-03-17 7:11 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44088bfc-1700-fc0c-7cd7-896ad7d43d1b@gmail.com \
--to=numbchild@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).