From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] org-src-edit support open edit buffer bellow current window Date: Sat, 17 Mar 2018 12:26:27 +0800 Message-ID: <44088bfc-1700-fc0c-7cd7-896ad7d43d1b@gmail.com> References: <9072a04c-f0f2-50c4-c3aa-dfc9fd647b7f@gmail.com> <87lgew8jw4.fsf@nicolasgoaziou.fr> <439b5c66-151f-2f97-a119-2b726d5e5fd0@gmail.com> <7a40563f-df54-c73b-1d69-60f95cfd20b1@gmail.com> <874llfae0i.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7B071C2C67A971538E8DBD6C" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ex3QV-0000AB-0p for emacs-orgmode@gnu.org; Sat, 17 Mar 2018 00:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ex3QQ-0002Su-2r for emacs-orgmode@gnu.org; Sat, 17 Mar 2018 00:26:39 -0400 Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:41672) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ex3QP-0002QX-O9 for emacs-orgmode@gnu.org; Sat, 17 Mar 2018 00:26:34 -0400 Received: by mail-pg0-x22e.google.com with SMTP id w17so4868125pgq.8 for ; Fri, 16 Mar 2018 21:26:33 -0700 (PDT) In-Reply-To: <874llfae0i.fsf@nicolasgoaziou.fr> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: org-mode This is a multi-part message in MIME format. --------------7B071C2C67A971538E8DBD6C Content-Type: multipart/alternative; boundary="------------53FDB69858187A21D81C626F" --------------53FDB69858187A21D81C626F Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit regenerated patch against HEAD now. Check it out. Thanks for your review. On 03/17/2018 05:47 AM, Nicolas Goaziou wrote: > Hello, > > stardiviner writes: > >> Hi, @Nicolas is this patch still has any thing need to change? > It doesn't apply on master branch. Could you rebase it against HEAD and > send it again? > > Thank you. > > Regards, > --------------53FDB69858187A21D81C626F Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

regenerated patch against HEAD now. Check it out. Thanks for your review.


On 03/17/2018 05:47 AM, Nicolas Goaziou wrote:
Hello,

stardiviner <numbchild@gmail.com> writes:


Hi, @Nicolas is this patch still has any thing need to change?

It doesn't apply on master branch. Could you rebase it against HEAD and
send it again?

Thank you.

Regards,

--------------53FDB69858187A21D81C626F-- --------------7B071C2C67A971538E8DBD6C Content-Type: text/x-patch; name="0001-org-src.el-org-src-window-setup-support-open-edit-sr.patch" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename*0="0001-org-src.el-org-src-window-setup-support-open-edit-sr.pa"; filename*1="tch" >From fc84014b600afb3eb23fc2e73c359aed5c0791af Mon Sep 17 00:00:00 2001 From: stardiviner Date: Tue, 13 Mar 2018 01:23:52 +0800 Subject: [PATCH] org-src.el: (org-src-window-setup) support open edit src window below. TINYCHANGE --- etc/ORG-NEWS | 2 ++ lisp/org-src.el | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS index 01a9361df..c14bbe1d4 100644 --- a/etc/ORG-NEWS +++ b/etc/ORG-NEWS @@ -113,6 +113,8 @@ now sort according to the locale’s collation rules instead of by code-point. ** New features +*** Add support for open src block in below window +Set option ~org-src-window-setup~ to ~'split-window-below~. *** Add support for links to LaTeX equations in HTML export Use MathJax links when enabled (by ~org-html-with-latex~), otherwise add a label to the rendered equation. diff --git a/lisp/org-src.el b/lisp/org-src.el index dfa2ae3de..5d3c2e538 100644 --- a/lisp/org-src.el +++ b/lisp/org-src.el @@ -155,6 +155,8 @@ Possible values for this option are: current-window Show edit buffer in the current window, keeping all other windows. +split-window-below Show edit buffer below the current window, keeping all + other windows. other-window Use `switch-to-buffer-other-window' to display edit buffer. reorganize-frame Show only two windows on the current frame, the current window and the edit buffer. When exiting the edit buffer, @@ -164,6 +166,7 @@ other-frame Use `switch-to-buffer-other-frame' to display edit buffer. :group 'org-edit-structure :type '(choice (const current-window) + (const split-window-below) (const other-frame) (const other-window) (const reorganize-frame))) @@ -746,6 +749,9 @@ If BUFFER is non-nil, test it instead." (`current-window (pop-to-buffer-same-window buffer)) (`other-window (switch-to-buffer-other-window buffer)) + (`split-window-below + (select-window (split-window-vertically)) + (pop-to-buffer-same-window buffer)) (`other-frame (pcase context (`exit -- 2.16.2 --------------7B071C2C67A971538E8DBD6C--