* FAILED test-org/end-of-line
@ 2012-11-27 18:45 Achim Gratz
2012-11-27 21:15 ` Nick Dokos
0 siblings, 1 reply; 8+ messages in thread
From: Achim Gratz @ 2012-11-27 18:45 UTC (permalink / raw)
To: emacs-orgmode
This test is failing again in the latest pre-test version of the pending
Emacs 24.3 release. This time it fails on Linux, it used to fail before
in Emacs 23.3 on Win7.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-27 18:45 FAILED test-org/end-of-line Achim Gratz
@ 2012-11-27 21:15 ` Nick Dokos
2012-11-27 21:47 ` Nick Dokos
0 siblings, 1 reply; 8+ messages in thread
From: Nick Dokos @ 2012-11-27 21:15 UTC (permalink / raw)
To: Achim Gratz; +Cc: emacs-orgmode
Achim Gratz <Stromeko@nexgo.de> wrote:
>
> This test is failing again in the latest pre-test version of the pending
> Emacs 24.3 release. This time it fails on Linux, it used to fail before
> in Emacs 23.3 on Win7.
>
>
Ugh - one of "those"...
With the minimal.org-test.el file appended, I get no problems with -q:
,----
| $ emacs -q -l ~/src/minimal.emacs/minimal.org-test.el
| $ echo $?
| 0
`----
but -batch is another story:
,----
| $ emacs -batch -l ~/src/minimal.emacs/minimal.org-test.el
| Loading /home/nick/src/emacs/org/org-mode/lisp/org-loaddefs.el (source)...
| Loading /home/nick/src/emacs/org/org-mode/testing/org-test.el (source)...
| `labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| Loading /home/nick/src/emacs/org/org-mode/testing/lisp/test-org.el (source)...
| Running 1 tests (2012-11-27 16:02:29-0500)
| OVERVIEW
| OVERVIEW
| OVERVIEW
| OVERVIEW
| Test test-org/end-of-line backtrace:
| signal(ert-test-failed (((should (org-test-with-temp-text "* Headlin
| ert-fail(((should (org-test-with-temp-text "* Headline2 :tag:" (let
| (if (unwind-protect (setq value-290 (let ((temp-buffer (generate-new
| (let (form-description-291) (if (unwind-protect (setq value-290 (let
| (let ((value-290 (ert--gensym "ert-form-evaluation-aborted-"))) (let
| (lambda nil (let ((value-284 (ert--gensym "ert-form-evaluation-abort
| byte-code("\306\307!\x18q\210\310\216\311 \x19\312\216\313\314\315\316\3
| ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
| byte-code("\306\307!\211\x18\211\x19r\310\311!q\210\312 d\313\223)L\210)\3
| ert-run-test([cl-struct-ert-test test-org/end-of-line "Test `org-end
| ert-run-or-rerun-test([cl-struct-ert--stats test-org/end-of-line [[c
| ert-run-tests(test-org/end-of-line #[(event-type &rest event-args) "
| ert-run-tests-batch(test-org/end-of-line)
| ert-run-tests-batch-and-exit(test-org/end-of-line)
| eval-buffer(#<buffer *load*> nil "/home/nick/src/minimal.emacs/mini
| load-with-code-conversion("/home/nick/src/minimal.emacs/minimal.org-
| load("/home/nick/src/minimal.emacs/minimal.org-test.el" nil t)
| command-line-1(("-l" "/home/nick/src/minimal.emacs/minimal.org-test.
| command-line()
| normal-top-level()
| Test test-org/end-of-line condition:
| (ert-test-failed
| ((should
| (org-test-with-temp-text "* Headline2 :tag:"
| (let ... ...)))
| :form
| (let
| ((temp-buffer ...))
| (with-current-buffer temp-buffer
| (unwind-protect ... ...)))
| :value nil))
| FAILED 1/1 test-org/end-of-line
|
| Ran 1 tests, 0 results as expected, 1 unexpected (2012-11-27 16:02:30-0500)
|
| 1 unexpected results:
| FAILED test-org/end-of-line
`----
and
,----
| $ echo $?
| 1
`----
Double-plus unnice.
Nick
--8<---------------cut here---------------start------------->8---
;;; -*- mode: emacs-lisp -*-
;;; constant part
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/contrib/lisp"))
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org)
(setq debug-on-error t)
(setq debug-on-quit t)
(setq eval-expression-print-length nil)
(setq eval-expression-print-level nil)
(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/testing"))
(load-library "org-test")
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/testing/lisp"))
(load-library "test-org")
(ert-run-tests-batch-and-exit 'test-org/end-of-line)
--8<---------------cut here---------------end--------------->8---
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-27 21:15 ` Nick Dokos
@ 2012-11-27 21:47 ` Nick Dokos
2012-11-28 13:07 ` Nicolas Goaziou
0 siblings, 1 reply; 8+ messages in thread
From: Nick Dokos @ 2012-11-27 21:47 UTC (permalink / raw)
Cc: Achim Gratz, emacs-orgmode
Nick Dokos <nicholas.dokos@hp.com> wrote:
> Achim Gratz <Stromeko@nexgo.de> wrote:
>
> >=20
> > This test is failing again in the latest pre-test version of the pending
> > Emacs=C2=A024.3 release. This time it fails on Linux, it used to fail be=
> fore
> > in Emacs=C2=A023.3 on Win7.
> >=20
> >=20
>
> Ugh - one of "those"...
>
Adding a \n at the end of the headline lets the test pass I think:
,----
| $ emacs -batch -l ~/src/minimal.emacs/minimal.org-test.el
| Loading /home/nick/src/emacs/org/org-mode/lisp/org-loaddefs.el (source)...
| Loading /home/nick/src/emacs/org/org-mode/testing/org-test.el (source)...
| `labels' is an obsolete macro (as of 24.3); use `cl-labels' instead.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| `flet' is an obsolete macro (as of 24.3); Use either `cl-flet' or `cl-letf'.
| OVERVIEW
| FOO
| 18
| Ran 1 tests, 1 results were as expected
`----
Nick
PS. FOO and 18 are debugging things - see the new minimal.org-test.el file below:
--8<---------------cut here---------------start------------->8---
;;; -*- mode: emacs-lisp -*-
;;; constant part
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/lisp"))
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/contrib/lisp"))
(add-to-list 'auto-mode-alist '("\\.\\(org\\|org_archive\\|txt\\)$" . org-mode))
(require 'org)
(setq debug-on-error t)
(setq debug-on-quit t)
(setq eval-expression-print-length nil)
(setq eval-expression-print-level nil)
(global-set-key "\C-cl" 'org-store-link)
(global-set-key "\C-ca" 'org-agenda)
(add-to-list 'load-path (expand-file-name "~/src/emacs/org/org-mode/testing"))
(load-library "org-test")
(ert-deftest test-org/end-of-line ()
"Test `org-end-of-line' specifications."
;; At an headline without special movement.
(should
(org-test-with-temp-text "* Headline2 :tag:\n"
(let ((org-special-ctrl-a/e nil))
(and (progn (message "FOO") (org-end-of-line) (message (format "%d" (point))) (eolp))
(progn (org-end-of-line) (eolp))))))
)
(ert 'test-org/end-of-line)
--8<---------------cut here---------------end--------------->8---
Without the \n, (point) was returning 1 in the batch case (?!?)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-27 21:47 ` Nick Dokos
@ 2012-11-28 13:07 ` Nicolas Goaziou
2012-11-28 15:51 ` Nick Dokos
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2012-11-28 13:07 UTC (permalink / raw)
To: nicholas.dokos; +Cc: Achim Gratz, emacs-orgmode
Hello,
Nick Dokos <nicholas.dokos@hp.com> writes:
> Adding a \n at the end of the headline lets the test pass I think:
I've added "\n" at the end of headlines. Since I don't use pretest
version, can you confirm it does indeed fix the problem?
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-28 13:07 ` Nicolas Goaziou
@ 2012-11-28 15:51 ` Nick Dokos
2012-11-28 15:53 ` Nicolas Goaziou
0 siblings, 1 reply; 8+ messages in thread
From: Nick Dokos @ 2012-11-28 15:51 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: Achim Gratz, emacs-orgmode
Nicolas Goaziou <n.goaziou@gmail.com> wrote:
> Hello,
>
> Nick Dokos <nicholas.dokos@hp.com> writes:
>
> > Adding a \n at the end of the headline lets the test pass I think:
>
> I've added "\n" at the end of headlines. Since I don't use pretest
> version, can you confirm it does indeed fix the problem?
>
I don't use the pretest version either, but the version I do use
GNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.4) of 2012-09-21
exhibited the failure before. With the change above, it no longer fails
for me.
Can you also disambiguate the headlines in the three cases? That would
make obvious *which* of the three subtests failed (for the record, it
was the second one, i.e. org-special-ctrl-a/e nil - the other two were
OK for some reason).
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-28 15:51 ` Nick Dokos
@ 2012-11-28 15:53 ` Nicolas Goaziou
2012-11-28 17:51 ` Achim Gratz
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Goaziou @ 2012-11-28 15:53 UTC (permalink / raw)
To: nicholas.dokos; +Cc: Achim Gratz, emacs-orgmode
Nick Dokos <nicholas.dokos@hp.com> writes:
> Can you also disambiguate the headlines in the three cases? That would
> make obvious *which* of the three subtests failed (for the record, it
> was the second one, i.e. org-special-ctrl-a/e nil - the other two were
> OK for some reason).
Done.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-28 15:53 ` Nicolas Goaziou
@ 2012-11-28 17:51 ` Achim Gratz
2012-11-28 17:59 ` Nick Dokos
0 siblings, 1 reply; 8+ messages in thread
From: Achim Gratz @ 2012-11-28 17:51 UTC (permalink / raw)
To: emacs-orgmode
Nicolas Goaziou writes:
> Done.
I confirm that the test failed before those two changes, but passes
after. I am however unable at the moment to test it on any 23.x version
of Emacs, so I don't know if that might present a regression there.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: FAILED test-org/end-of-line
2012-11-28 17:51 ` Achim Gratz
@ 2012-11-28 17:59 ` Nick Dokos
0 siblings, 0 replies; 8+ messages in thread
From: Nick Dokos @ 2012-11-28 17:59 UTC (permalink / raw)
To: Achim Gratz; +Cc: emacs-orgmode
Achim Gratz <Stromeko@nexgo.de> wrote:
> Nicolas Goaziou writes:
> > Done.
>
> I confirm that the test failed before those two changes, but passes
> after. I am however unable at the moment to test it on any 23.x version
> of Emacs, so I don't know if that might present a regression there.
>
>
Given the previous problems on Windows, it would be good if somebody tested it
there as well.
Nick
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-11-28 17:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-27 18:45 FAILED test-org/end-of-line Achim Gratz
2012-11-27 21:15 ` Nick Dokos
2012-11-27 21:47 ` Nick Dokos
2012-11-28 13:07 ` Nicolas Goaziou
2012-11-28 15:51 ` Nick Dokos
2012-11-28 15:53 ` Nicolas Goaziou
2012-11-28 17:51 ` Achim Gratz
2012-11-28 17:59 ` Nick Dokos
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).