Re: [ANN] org-icons.el

From: Carsten Dominik <carsten.dominik@gmail.com>
To: Nicolas Girard <nicolas.girard@nerim.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [ANN] org-icons.el
Date: Wed, 24 Jun 2009 11:48:28 +0200	[thread overview]
Message-ID: <41C49548-6364-4A9A-86D3-3E70DD5E245D@gmail.com> (raw)
In-Reply-To: <51b0095d0906240241v57fb7191u90ed1d87d0585c69@mail.gmail.com>

On Jun 24, 2009, at 11:41 AM, Nicolas Girard wrote:

> 2009/6/24 Carsten Dominik <carsten.dominik@gmail.com>
> Could you guys please first explain the
>
>
>  ;; This part is buggy (sorry)
>
> comment in the patch?
>
> Err... this just reflects my current lack of expressiveness in  
> elisp... don't make me blush :-/

I am not complaining, no need to blush.

The patch looks good.  It does not add any hooks though, it
moves some of the font-lock functionality into special functions
that will then be overwritten by the org-icons package.  A bit of
a brute force approach, but it may actually be the right thing
for this purpose.

I think I can easily apply the patch - I even like the fact that
it cleans up the font locking a bit and moves stuff into functions.

But if this patch is preliminary, keep working on it and give me
a more complete version when done.

Best wishes

- Carsten

>
> What David meant was not to ask you to integrate a ready-to-go  
> patch, but just to ask you to have a first look at the changes need  
> to be made to org.el, and tell us if you'd be inclined to accept  
> them, when they are ready.
>
> The changes only consists in adding more hooks to org's font locking  
> mechanism --- at least that's the idea ; the probability of mistakes  
> in my implementation is above 100%...
>
> Nicolas
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode