From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: [ANN] org-icons.el Date: Wed, 24 Jun 2009 11:48:28 +0200 Message-ID: <41C49548-6364-4A9A-86D3-3E70DD5E245D@gmail.com> References: <51b0095d0906231238u62ed3107v79dd6f72a284d81b@mail.gmail.com> <64bfe3d50906231554n43790a74p739bc0e7ff426b14@mail.gmail.com> <87my7yeeai.fsf@bzg.ath.cx> <64bfe3d50906231616l4ad64907sa49daa8f826d0248@mail.gmail.com> <51b0095d0906240241v57fb7191u90ed1d87d0585c69@mail.gmail.com> Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJP5q-0000J8-TL for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 05:48:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJP5m-0000IB-V8 for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 05:48:38 -0400 Received: from [199.232.76.173] (port=47843 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJP5m-0000I7-LG for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 05:48:34 -0400 Received: from mail-ew0-f220.google.com ([209.85.219.220]:39842) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MJP5m-00017D-5M for emacs-orgmode@gnu.org; Wed, 24 Jun 2009 05:48:34 -0400 Received: by ewy20 with SMTP id 20so1052010ewy.42 for ; Wed, 24 Jun 2009 02:48:32 -0700 (PDT) In-Reply-To: <51b0095d0906240241v57fb7191u90ed1d87d0585c69@mail.gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Girard Cc: emacs-orgmode@gnu.org On Jun 24, 2009, at 11:41 AM, Nicolas Girard wrote: > 2009/6/24 Carsten Dominik > Could you guys please first explain the > > > ;; This part is buggy (sorry) > > comment in the patch? > > Err... this just reflects my current lack of expressiveness in > elisp... don't make me blush :-/ I am not complaining, no need to blush. The patch looks good. It does not add any hooks though, it moves some of the font-lock functionality into special functions that will then be overwritten by the org-icons package. A bit of a brute force approach, but it may actually be the right thing for this purpose. I think I can easily apply the patch - I even like the fact that it cleans up the font locking a bit and moves stuff into functions. But if this patch is preliminary, keep working on it and give me a more complete version when done. Best wishes - Carsten > > What David meant was not to ask you to integrate a ready-to-go > patch, but just to ask you to have a first look at the changes need > to be made to org.el, and tell us if you'd be inclined to accept > them, when they are ready. > > The changes only consists in adding more hooks to org's font locking > mechanism --- at least that's the idea ; the probability of mistakes > in my implementation is above 100%... > > Nicolas > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode